Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Pool only when HTTP response fully read #255

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[Feature] Pool only when HTTP response fully read #255

wants to merge 16 commits into from

Conversation

GuyLewin
Copy link
Contributor

Fixes #253

@GuyLewin GuyLewin changed the title [Feature] Pool only when HTTP body read [Feature] Pool only when HTTP response fully read Oct 13, 2021
@GuyLewin GuyLewin force-pushed the feature/pool-only-when-http-body-read branch from 550781d to 5c9308b Compare October 13, 2021 14:16
@GuyLewin
Copy link
Contributor Author

@pintsized I hope I didn't change too many internals here. I had to do some changes to make sure this is correct with and without trailers. Let me know what you think, I'm open to make changes.

@GuyLewin
Copy link
Contributor Author

@pintsized thanks for merging #254 . I merged 'master'

Tieske
Tieske reviewed Feb 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
pintsized
pintsized requested changes Feb 2, 2022
View reviewed changes
Copy link
Member

@pintsized pintsized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks for this - it does seem like an important feature. I think we can ditch the config option for sure, but I've left some notes wrt the overall callback / coroutine technique being used. I think perhaps there's a simpler solution available, which will have less overhead?

lib/resty/http.lua Outdated Show resolved Hide resolved
lib/resty/http.lua Outdated Show resolved Hide resolved
lib/resty/http.lua Outdated Show resolved Hide resolved
@GuyLewin GuyLewin force-pushed the feature/pool-only-when-http-body-read branch from 72c1375 to 2d4feca Compare April 20, 2022 14:44
@GuyLewin GuyLewin force-pushed the feature/pool-only-when-http-body-read branch from ae4ae87 to dece7fa Compare April 20, 2022 15:41
@GuyLewin GuyLewin force-pushed the feature/pool-only-when-http-body-read branch from dece7fa to 5d3a82c Compare April 20, 2022 15:49
@GuyLewin GuyLewin requested a review from pintsized April 20, 2022 15:54
@GuyLewin
Copy link
Contributor Author

@pintsized I rewrote the logic, I think it turned out pretty good. Let me know if you think we should change anything else.

@GuyLewin
Copy link
Contributor Author

@pintsized do you mind reviewing again before there's conflicts?

@pintsized
Copy link
Member

@GuyLewin yes, I will... sorry, I'm just very busy at the moment. It's on the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tieske Tieske Tieske left review comments

@pintsized pintsized Awaiting requested review from pintsized

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden set_keepalive() to pool only when response read
3 participants
@GuyLewin @pintsized @Tieske