C-c C-c ledger-toggle-current searches backwards indefinitely

[jstamant]

If the cursor isn't on a transaction, hitting C-c C-c (ledger-toggle-current) will search backwards until it finds a transaction, and then toggles its state.

The behavior is the same as in issue #316, where I explain this problem in a bit more detail. Like in #316, my suggestion here is to add some validation that only lets a user perform ledger-toggle-current when point is on a valid transaction or posting.

I'll probably provide a fix in a PR shortly.

[bcc32]

I can't reproduce this behavior. There have been a couple recent changes to ledger-toggle-current's implementation, so it might be fixed by now?

Can you provide a sample ledger file and a step-by-step reproduction example?

[jstamant]

Hey, Aaron. Gladly:

Upgrading ledger-mode to today's version on MELPA (20240322.2155) still produces the behavior for me.

Steps to reproduce

1. Download this sample file and open it with ledger-mode as the major mode
2. Goto to line 6 and hit C-c C-c (ledger-toggle-current)
3. Notice that the transaction above gets toggle. If this were a long section of comments, the command would silently occur.
4. Add a full window's worth of newlines at line 4 so that the transaction is no longer on screen
5. Goto the end of the file M-x end-of-buffer, and run M-x ledger-toggle-current again
6. Notice that the status for the transaction on line 1 get toggled. Silently

[bcc32]

Ah, thanks for the example. It turns out I also had to set ledger-clear-whole-transactions non-nil to trigger the bug. Fixing