Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report buffer not finding ledger executable #318

Open
titanofold opened this issue Oct 6, 2021 · 1 comment
Open

Report buffer not finding ledger executable #318

titanofold opened this issue Oct 6, 2021 · 1 comment

Comments

@titanofold
Copy link

Hi, all!

When running a report, I'm getting the following result:

Report: bal
Command: "ledger" -f "c:/Users/aswenson/Dropbox/financial/demo.ledger" bal
=====================================================================================================================

'"ledger"' is not recognized as an internal or external command,
operable program or batch file.

I believe this line needs executable-find:

(list (shell-quote-argument ledger-binary-path)

As otherwise ledger-mode appears to operate OK.

@purcell
Copy link
Member

purcell commented Oct 7, 2021

executable-find just looks up an executable on the current path, but it should make no difference here, because if a plain executable name is provided then Emacs will resolve it from the current path automatically. What's suspicious to me is the double quotes around ledger. If I recall correctly, it's not safe to do that on some platforms. I might guess that the right fix here would be to not call shell-quote-argument on ledger-binary-path. Perhaps you could try that out locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants