Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sheet header to show back instead of close in action popup #404

Open
pete-watters opened this issue Aug 29, 2024 · 2 comments
Open

Comments

@pete-watters
Copy link
Contributor

I'm opening this issue as a follow up to work on this leather-io/extension#5802

@mica000: recorded this loom to demonstrate issues with headers in action popups:
https://trustmachines.slack.com/archives/C05LRS7G44R/p1724349131407629?thread_ts=1724305603.462199&cid=C05LRS7G44R

The basic thing to change is that the Receive sheet should show a <- button instead of an X when in action popup mode.

Right now things work correctly for Send as thats actually a page and not a sheet.

@pete-watters pete-watters self-assigned this Aug 29, 2024
@pete-watters
Copy link
Contributor Author

@mica000 @fabric-8 : I need some advice on this. Do you want me to update all of the sheets so that they show <- when in the extension action popup?

We have many sheets and none of them are doing this right now:
https://github.com/user-attachments/assets/cb251c8b-6acd-4dcf-8391-2dd819d92375

The only place we do it is in the send flow as that's not using a sheet component. I can update it so they all follow the same approach? Or else pick some sheets like Receive.

I show in the video the example of Sign out which should also maybe show <- in action popup mode

@mica000 you can also see here that opening Receive / Send in the action popup opens it there and not in full page so I'm not sure what was happening in your video. Hopefully something that is fixed now.

CC @markmhendrickson in case you have input here

@pete-watters
Copy link
Contributor Author

@mica000 assigning this to you as I'm not sure if we want to do this or not - updating all of the action popups to have back instead of close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants