Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display of inscriptions with all supported mimetypes while signing PSBTs #5824

Open
314159265359879 opened this issue Aug 29, 2024 · 1 comment
Open

Support display of inscriptions with all supported mimetypes while signing PSBTs #5824

314159265359879 opened this issue Aug 29, 2024 · 1 comment
Labels
area:api area:bitcoin area:ordinals bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds

Comments

@314159265359879
Copy link
Contributor

Original message report from Mark

Our processing of PSBT outputs for displaying inscriptions (vs. just vanilla BTC) seems to be broken, based on a couple trades I just made via Magic Eden and Gamma.
Anastasios any idea if recent API work may have affected this?

image
https://trustmachines.slack.com/archives/C0520G8J33M/p1724945992528689
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds area:bitcoin area:ordinals labels Aug 29, 2024
@314159265359879 314159265359879 mentioned this issue Aug 29, 2024
Open
@markmhendrickson markmhendrickson changed the title Fix processing of PSBT's to display inscriptions in addition to BTC Support display of inscriptions with all supported mimetypes while signing PSBTs Sep 3, 2024
@markmhendrickson
Copy link
Collaborator

We should presumably support the display of all the same mimetypes (e.g. HTML) during PSBT signing as we do already when displaying these inscriptions under collectibles on the home view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api area:bitcoin area:ordinals bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@markmhendrickson @314159265359879 @alter-eggo and others