show users that unenrolled prior to the allocation in a seperate row #199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
============================================
- Coverage 25.74% 25.58% -0.17%
- Complexity 767 772 +5
============================================
Files 43 43
Lines 3247 3268 +21
============================================
Hits 836 836
- Misses 2411 2432 +21
Continue to review full report at Codecov.
|
| @@ -160,17 +160,42 @@ public function build_table_by_sql() { | |||
| $noallocation->choicetitle = get_string( | |||
| 'allocations_table_noallocation', | |||
| ratingallocate_MOD_NAME); | |||
| $enrolled_user_ids = array_map(function($x) {return $x->id;}, | |||
| $this->ratingallocate->get_raters_in_course()); | |||
There was a problem hiding this comment.
instead of $this->ratingallocate->get_raters_in_course(), you could use $users
| if (object_property_exists($noallocation, 'users')) { | ||
| $noallocation->users .= ', '; | ||
| } else { | ||
| $noallocation->users = ''; | ||
| } | ||
| $noallocation->users .= $this->get_user_link($user); | ||
| unset($userwithrating[$userid]); | ||
| } | ||
| $data []= $noallocation; |
There was a problem hiding this comment.
If there are no unallocated users, $noallocation->users will be undefined. You could put all userlinks for noallocation in an array, and set $noallocation->users = implode(', ', $noallocationusers) afterwards (or do it the same way as around line 151).
Same goes for $unenrolled.
It looks like the problem has already existed before this PR, but it seems a good opportunity to fix it :)
closes #166