Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withRouter missing #21

Open
skimming opened this issue Nov 15, 2016 · 3 comments
Open

withRouter missing #21

skimming opened this issue Nov 15, 2016 · 3 comments
Assignees
Labels

Comments

@skimming
Copy link

Couldn't get the routing from PokemonPreviewPage back to ListPage. Kept complaining about this.props.router being null. Solved via wrapping ala <Route ... component={withRouter(PokemonPage)}.

@marktani marktani self-assigned this Nov 16, 2016
@marktani
Copy link
Member

Aw man. Problems around router are clearly the most reported issues. It's on my list but can't look into it right now.

@marktani marktani added the bug label Nov 16, 2016
@bdougie
Copy link

bdougie commented Dec 20, 2016

Stumbled on this as well, is this a limitation with react-router-relay?

It seemed like routing never worked while going through all the steps, but I ignored until step-7 when I started to investigate and noticed the routing went from this.props.router in the branches to this.context.router in the solutions.

@bdougie
Copy link

bdougie commented Dec 20, 2016

Ah total misread your issue @skimming. Wrapping withRouter is more ideal than using this.context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants