Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for Search Feature Very Vague #698

Open
jasminetealady opened this issue May 24, 2018 · 0 comments
Open

Instructions for Search Feature Very Vague #698

jasminetealady opened this issue May 24, 2018 · 0 comments

Comments

@jasminetealady
Copy link
Collaborator

I lost some time on this lab due to confusion over the instructions and tests for this line:

"Add in search functionality such that users can search for a student by name and see all matching results on the students index page. The results should be displayed by rendering a students/_student.html.erb partial."

I understood I had to create a search method in the Student model and did so, but the instructions/tests imply that one need to search something first in order to display the results. In the students index file, what passes these tests is to iterate over @Students or Student.all as usual in an index file, but that's not the same as iterating over an array of search results, so was very confusing.

Some clearer instructions and specs could help future students avoid this confusion. Thanks!

Razelle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant