Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe show a certain paragraph after the example for preceding paragraph, not before #4

Open
brigj1 opened this issue Jul 31, 2022 · 0 comments
Labels
se curriculum Issue for lessons in the Software Engineering program

Comments

@brigj1
Copy link

brigj1 commented Jul 31, 2022

Canvas Link

https://learning.flatironschool.com/courses/5188/assignments/181024?module_item_id=399413

Concern

There is example code that follows the two paragraphs listed here. The example code shows usage for the first paragraph. Great! The second paragraph ends with "for example." I was not reading carefully and interpreted that as saying the example illustrated the second paragraph's guidance in action. Oops on my part, but the words and sequencing of the material made it easy to misinterpret.

Don't forget to enable [CORS (Links to an external site.)](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS) in your app. Uncomment the following in [config/initializers/cors.rb](https://learning.flatironschool.com/server/config/initializers/cors.rb). Don't forget to change the origins from example.com to *

Depending on the use-case and needs of our API, we might want to limit access to our app. For example, if our React frontend is deployed to myCoolReactApp.com, we might want to limit access to that domain only. If certain endpoints are meant to be public, we can make those available but limit to GET requests, for example.

Additional Context

No response

Suggested Changes

The example code that follows the two paragraphs listed above should follow the first paragraph, not the second one.

@brigj1 brigj1 added the se curriculum Issue for lessons in the Software Engineering program label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
se curriculum Issue for lessons in the Software Engineering program
Projects
None yet
Development

No branches or pull requests

1 participant