Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onend event don't work on Safari #226

Open
alexlana opened this issue Nov 10, 2023 · 2 comments
Open

onend event don't work on Safari #226

alexlana opened this issue Nov 10, 2023 · 2 comments
Assignees

Comments

@alexlana
Copy link

Is your feature request related to a problem? Please describe.
The end event is messy in Safari.

Describe the solution you'd like
By adding window. before the variable utterance it works perfectly in Safari.

I worked on it in a fork, if you think it can be helpful, I will love to contribute.

@jankapunkt
Copy link
Member

jankapunkt commented Nov 10, 2023

Hey @alexlana thank your for reporting. Can you please specify the line of the code, where utterance exists? => https://github.com/jankapunkt/easy-speech/blob/master/src/EasySpeech.js

Of course, I would be very pleased to see a pull request on this.

@jankapunkt
Copy link
Member

@alexlana where do you actually put window in front of utterance?

@jankapunkt jankapunkt added the help wanted Extra attention is needed label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants