From 38526c23575a1d683851a5340c4453f197969651 Mon Sep 17 00:00:00 2001
From: Matthew Warman <warmanmr@gmail.com>
Date: Tue, 14 Nov 2023 13:39:23 -0500
Subject: [PATCH] SLSCMN-4 error  handler tests

---
 src/middlewares/error-handler-http.test.ts | 140 +++++++++++++++++++++
 1 file changed, 140 insertions(+)
 create mode 100644 src/middlewares/error-handler-http.test.ts

diff --git a/src/middlewares/error-handler-http.test.ts b/src/middlewares/error-handler-http.test.ts
new file mode 100644
index 0000000..1245ed9
--- /dev/null
+++ b/src/middlewares/error-handler-http.test.ts
@@ -0,0 +1,140 @@
+import { Request } from '@middy/core';
+import { jest } from '@jest/globals';
+
+import { HttpError, ServiceError } from '../errors';
+
+import { httpErrorHandler } from './error-handler-http';
+import { requestFixture } from '../__fixtures__/middy.fixture';
+
+describe('HttpErrorHandler', () => {
+  it('should create the middleware', () => {
+    const middleware = httpErrorHandler();
+
+    expect(middleware.before).not.toBeDefined();
+    expect(middleware.after).not.toBeDefined();
+    expect(middleware.onError).toBeDefined();
+  });
+
+  it('should do nothing when response has been written', () => {
+    const response = JSON.stringify({ foo: 'bar' });
+    const request: Request = {
+      ...requestFixture,
+      response,
+    };
+
+    const middleware = httpErrorHandler();
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(request.response).toBe(response);
+  });
+
+  it('should do nothing when no error', () => {
+    const request: Request = {
+      ...requestFixture,
+    };
+    delete request.response;
+
+    const middleware = httpErrorHandler();
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(request.response).not.toBeDefined();
+  });
+
+  it('should write log when logger provided', () => {
+    type loggerFn = (msg: string) => void;
+    const mockLogger = jest.fn<loggerFn>();
+    const request: Request = {
+      ...requestFixture,
+      error: new HttpError('message', 404),
+    };
+    delete request.response;
+
+    const middleware = httpErrorHandler({
+      defaultMessage: 'message',
+      defaultStatusCode: 500,
+      logger: mockLogger,
+    });
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(mockLogger).toHaveBeenCalled();
+  });
+
+  it('should handle HttpError', () => {
+    const expectedResponse = {
+      body: JSON.stringify({ name: 'HttpError', message: 'message', code: 500, statusCode: 500 }),
+      statusCode: 500,
+    };
+    const request: Request = {
+      ...requestFixture,
+      error: new HttpError('message', 500),
+    };
+    delete request.response;
+
+    const middleware = httpErrorHandler();
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(request.response).toStrictEqual(expectedResponse);
+  });
+
+  it('should handle ServiceError', () => {
+    const expectedResponse = {
+      body: JSON.stringify({
+        name: 'ServiceError',
+        message: 'message',
+        code: 500,
+        statusCode: 500,
+      }),
+      statusCode: 500,
+    };
+    const request: Request = {
+      ...requestFixture,
+      error: new ServiceError('message'),
+    };
+    delete request.response;
+
+    const middleware = httpErrorHandler();
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(request.response).toStrictEqual(expectedResponse);
+  });
+
+  it('should handle Error', () => {
+    const expectedResponse = {
+      body: JSON.stringify({
+        name: 'Error',
+        message: 'message',
+        code: 500,
+        statusCode: 500,
+      }),
+      statusCode: 500,
+    };
+    const request: Request = {
+      ...requestFixture,
+      error: new Error('message'),
+    };
+    delete request.response;
+
+    const middleware = httpErrorHandler();
+
+    expect(middleware.onError).toBeDefined();
+
+    middleware.onError?.(request);
+
+    expect(request.response).toStrictEqual(expectedResponse);
+  });
+});