-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not count un-deprecations in Mathlib/Deprecated
#19184
base: master
Are you sure you want to change the base?
fix: do not count un-deprecations in Mathlib/Deprecated
#19184
Conversation
PR summary 035c73548dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for Increase in tech debt: (relative, absolute) = (1.00, 0.01)
Current commit 035c73548d You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggestion but it looks good enough to me either way, thanks!
bors d+
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
Given how the discussion evolved in the Zulip chat, I am going to extract this using a variation of # count total number of `set_option linter.deprecated false`
deprecs="$(git grep -c "set_option linter.deprecated false" | awk -F: 'BEGIN{total=0} {total+=$2} END{print total}')"
# count the `linter.deprecated` exceptions that are themselves ones that are followed by `deprecated ...(since`
doubleDeprecs="$(git grep -A1 "set_option linter.deprecated false" | grep -c "deprecated .*(since")"
echo "$(( deprecs - doubleDeprecs ))" that only searches outside the |
…ons' of github.com:leanprover-community/mathlib4 into adomani/tech_debts_do_not_report_deprecated_undeprecations
80ee4b9
to
035c735
Compare
Reported on Zulip