-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making guzzle
dependencies optional for optional Remote Xdebug support
#15
Comments
I have released 2 new versions of this extension today:
Whatever decision we make after gathering feedback here, will affect only future versions ( |
Thanks for updating! Making it optional wouldn't break anything here, as I don't use the Remote XDebug functionality. If a clear errormessage is thrown in case Guzzle is missing it would be very obvious how to fix things. Perhaps providing adapters for different Guzzle versions is a solution for the longer term, as you can just maintain 1 version of this repo, which can be updated. Changes in Guzzle can be covered in the adapters. |
I'd prefer |
I agree with the |
Currently for Remote XDebug functionality we are depending on Guzzle. As Guzzle is popular library, we have to be quite open about supported versions so this package does not conflict with versions of the library that developers can be using (related issues: #14 ).
It would be nice to gather feedback from everyone regarding what we do with Guzzle. I believe our options are:
Move
guzzlehttp/guzle
fromrequired
tosuggested
incomposer.json
. This would make this dependency optional and only those, who use Remote XDebug would need to install it separately. This would allow developers to use any version of guzzle and ignore the Remote XDebug functionality if they do not use it. This would be reflected in the documentation etc.Leave the
guzzlehttp/guzzle
dependency as is.I would like to request feedback from everyone: would moving from
required
tosuggested
break some kind of compatibility or workflow that you currently use? Are there any problems that you have encountered due to us depending onguzzle
(i.e. if you use specific version of guzzle like in #10 )?I personally would be in favour of move to
suggested
, but this might result in worse support for Remote Xdebug.Thank you for your time and don't be shy to provide feedback!
The text was updated successfully, but these errors were encountered: