Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add rules to keep accessibility and performances as high as possible #95

Open
legrandgrand opened this issue Oct 21, 2021 · 0 comments
Labels
enhancement New feature or request needs triage The issue or pull request could use eyes on it nice to have an issue that would be nice to have but priortivze others first

Comments

@legrandgrand
Copy link

What are you wanting to be added?

speedrun.website should be opened to everyone and every computer, every kind of connection. As such, we need to make sure that this stays a priority whenever we create new features or when we change the UI.

In order to do so, we need to make sure to respect as many rules of the WCAG (https://www.w3.org/WAI/standards-guidelines/wcag/ ) which gives all the standard for accessibility, and at least stay at AA standard. To do so, I propose to setup eslint a11y (https://www.npmjs.com/package/eslint-plugin-vue-a11y) on the project, which follows these rules.

We should also use Lighthouse on the CI ( https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/getting-started.md ) to make sure we stay high on both performances and accessibility.

TL;DR:

  • Setup a11y rules with Eslint for local development
  • Setup Lighthouse on the CI to measure performances and accessibility
  • Fix whatever else needs to be fixed to meet our standard: I advice going for AA.

What might break?

Nothing should break; if anything it should make fix stuff for accessibility purpose :D

Relevant Issues

N/A

@legrandgrand legrandgrand added enhancement New feature or request needs triage The issue or pull request could use eyes on it labels Oct 21, 2021
@zysim zysim self-assigned this Nov 13, 2021
@zysim zysim removed their assignment May 28, 2022
@buffet-time buffet-time moved this to To do in MVP Oct 24, 2022
@buffet-time buffet-time added this to MVP Oct 24, 2022
@buffet-time buffet-time added the nice to have an issue that would be nice to have but priortivze others first label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage The issue or pull request could use eyes on it nice to have an issue that would be nice to have but priortivze others first
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

4 participants