From 0517c5b501d1fb903143c585c2488239b231e21e Mon Sep 17 00:00:00 2001
From: zysim <9867871+zysim@users.noreply.github.com>
Date: Fri, 10 May 2024 22:11:22 +0800
Subject: [PATCH] Address comments

---
 .vscode/launch.json                           | 21 -------------------
 .../LeaderboardInfo/LeaderboardInfo.vue       |  8 +++----
 .../buttons/Dropdown/Dropdown.test.ts         |  7 +++++--
 .../elements/buttons/Dropdown/Dropdown.vue    |  3 +--
 .../api/useGetLeaderboardDetail/index.ts      |  7 +++++--
 lib/api/Account.ts                            |  3 +--
 lib/api/Categories.ts                         |  3 +--
 lib/api/Leaderboards.ts                       |  3 +--
 lib/api/Runs.ts                               |  3 +--
 lib/api/Users.ts                              |  3 +--
 10 files changed, 20 insertions(+), 41 deletions(-)
 delete mode 100644 .vscode/launch.json

diff --git a/.vscode/launch.json b/.vscode/launch.json
deleted file mode 100644
index ba921f6e..00000000
--- a/.vscode/launch.json
+++ /dev/null
@@ -1,21 +0,0 @@
-{
-  // Use IntelliSense to learn about possible attributes.
-  // Hover to view descriptions of existing attributes.
-  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
-  "version": "0.2.0",
-  "configurations": [
-    {
-      "type": "firefox",
-      "request": "launch",
-      "name": "Vue",
-      "url": "http://localhost:3000",
-      "webRoot": "${workspaceFolder}",
-      "pathMappings": [
-        {
-          "url": "webpack:///src/",
-          "path": "${webRoot}/"
-        }
-      ]
-    }
-  ]
-}
diff --git a/components/blocks/LeaderboardInfo/LeaderboardInfo.vue b/components/blocks/LeaderboardInfo/LeaderboardInfo.vue
index a32058df..b0b76948 100644
--- a/components/blocks/LeaderboardInfo/LeaderboardInfo.vue
+++ b/components/blocks/LeaderboardInfo/LeaderboardInfo.vue
@@ -25,15 +25,15 @@ defineProps<LeaderboardInfoProps>()
 </script>
 
 <template>
-  <Desktop
-    v-if="!isMobile"
+  <Mobile
+    v-if="isMobile"
     data-testid="child"
     :leaderboard="leaderboard"
     :todo-platforms="todoPlatforms"
     @follow="emit('follow', leaderboard.id)"
   />
-  <Mobile
-    v-if="isMobile"
+  <Desktop
+    v-else
     data-testid="child"
     :leaderboard="leaderboard"
     :todo-platforms="todoPlatforms"
diff --git a/components/elements/buttons/Dropdown/Dropdown.test.ts b/components/elements/buttons/Dropdown/Dropdown.test.ts
index 2f633cdd..49a7f567 100644
--- a/components/elements/buttons/Dropdown/Dropdown.test.ts
+++ b/components/elements/buttons/Dropdown/Dropdown.test.ts
@@ -1,8 +1,11 @@
-import { enableAutoUnmount, mount } from '@vue/test-utils'
+import {
+  enableAutoUnmount,
+  mount,
+  type ComponentMountingOptions,
+} from '@vue/test-utils'
 import { getByTestId } from 'root/testUtils'
 import Dropdown from './Dropdown.vue'
 import DropdownItem from './DropdownItem.vue'
-import type { ComponentMountingOptions } from '@vue/test-utils'
 
 enableAutoUnmount(afterEach)
 
diff --git a/components/elements/buttons/Dropdown/Dropdown.vue b/components/elements/buttons/Dropdown/Dropdown.vue
index f416ceaa..c00aa1f9 100644
--- a/components/elements/buttons/Dropdown/Dropdown.vue
+++ b/components/elements/buttons/Dropdown/Dropdown.vue
@@ -1,8 +1,7 @@
 <script setup lang="ts">
 // Explicitly-importing these because tests don't like the auto-imports - zysim
-import { provide, ref } from 'vue'
+import { provide, ref, type Ref } from 'vue'
 import BaseButton from '../BaseButton/BaseButton.vue'
-import type { Ref } from 'vue'
 
 export interface SharedState {
   active: Ref<boolean>
diff --git a/composables/api/useGetLeaderboardDetail/index.ts b/composables/api/useGetLeaderboardDetail/index.ts
index 124c2de2..aae18688 100644
--- a/composables/api/useGetLeaderboardDetail/index.ts
+++ b/composables/api/useGetLeaderboardDetail/index.ts
@@ -1,7 +1,10 @@
 import { ref } from 'vue'
-import { useApi } from 'composables/useApi'
+import {
+  useApi,
+  type ApiResponse,
+  type optionalParameters,
+} from 'composables/useApi'
 import { Leaderboards } from 'lib/api/Leaderboards'
-import type { ApiResponse, optionalParameters } from 'composables/useApi'
 import type { LeaderboardViewModel } from 'lib/api/data-contracts'
 
 export async function useGetLeaderboardDetail(
diff --git a/lib/api/Account.ts b/lib/api/Account.ts
index 630ba8fa..72fa2fb6 100644
--- a/lib/api/Account.ts
+++ b/lib/api/Account.ts
@@ -19,8 +19,7 @@ import type {
   UserViewModel,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Account<
   SecurityDataType = unknown,
diff --git a/lib/api/Categories.ts b/lib/api/Categories.ts
index 47f00144..7448f358 100644
--- a/lib/api/Categories.ts
+++ b/lib/api/Categories.ts
@@ -15,8 +15,7 @@ import type {
   ProblemDetails,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Categories<
   SecurityDataType = unknown,
diff --git a/lib/api/Leaderboards.ts b/lib/api/Leaderboards.ts
index d007ff94..e044396f 100644
--- a/lib/api/Leaderboards.ts
+++ b/lib/api/Leaderboards.ts
@@ -16,8 +16,7 @@ import type {
   ProblemDetails,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Leaderboards<
   SecurityDataType = unknown,
diff --git a/lib/api/Runs.ts b/lib/api/Runs.ts
index ef614e8b..bb965b8b 100644
--- a/lib/api/Runs.ts
+++ b/lib/api/Runs.ts
@@ -16,8 +16,7 @@ import type {
   RunViewModel,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Runs<
   SecurityDataType = unknown,
diff --git a/lib/api/Users.ts b/lib/api/Users.ts
index 40498df8..6c133e4f 100644
--- a/lib/api/Users.ts
+++ b/lib/api/Users.ts
@@ -10,8 +10,7 @@
  */
 
 import type { ProblemDetails, UserViewModel } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { HttpClient } from './http-client'
+import { HttpClient, type RequestParams } from './http-client'
 
 export class Users<
   SecurityDataType = unknown,