Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[배포] v0.5.1(PR#81,PR#82) #83

Merged
merged 28 commits into from
Oct 4, 2023
Merged

[배포] v0.5.1(PR#81,PR#82) #83

merged 28 commits into from
Oct 4, 2023

Conversation

le2sky
Copy link
Owner

@le2sky le2sky commented Oct 4, 2023

구현 요약

  • 국세청 사업자등록정보 상태조회 서비스를 연동했습니다.
  • 가게 생성 시 주소 정보를 받도록 개선되었습니다.
  • 기능 개선으로 인해 버전이 0.5.0에서 0.5.1로 증가했습니다.

연관 이슈
close #79
close #80

le2sky and others added 28 commits October 1, 2023 22:33
[개선] 가게 생성 시 주소 정보 추가 (issue#79)
[기능 구현] 국세청 사업자등록정보 상태조회 서비스 연동(issue#80)
@le2sky le2sky added deployment 해치웠나? run: ci ci 과정 실행 해줘~ labels Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Test Results

227 tests   227 ✔️  30s ⏱️
  59 suites      0 💤
  59 files        0

Results for commit 7204ea2.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #83 (7204ea2) into main (0cad251) will increase coverage by 0.63%.
Report is 1 commits behind head on main.
The diff coverage is 99.22%.

@@             Coverage Diff              @@
##               main      #83      +/-   ##
============================================
+ Coverage     95.19%   95.83%   +0.63%     
- Complexity      258      310      +52     
============================================
  Files            60       69       +9     
  Lines           645      768     +123     
  Branches         31       37       +6     
============================================
+ Hits            614      736     +122     
  Misses           18       18              
- Partials         13       14       +1     
Files Coverage Δ
...lkitary/shop/web/request/RegisterShopWebRequest.kt 100.00% <100.00%> (ø)
...shop/application/port/input/RegisterShopRequest.kt 100.00% <100.00%> (ø)
...ry/shop/application/service/RegisterShopService.kt 100.00% <100.00%> (ø)
...main/kotlin/com/mealkitary/common/model/Address.kt 100.00% <100.00%> (ø)
...ain/kotlin/com/mealkitary/shop/domain/shop/Shop.kt 81.48% <100.00%> (+0.71%) ⬆️
...mealkitary/shop/domain/shop/address/ShopAddress.kt 100.00% <100.00%> (ø)
...mealkitary/shop/domain/shop/factory/ShopFactory.kt 100.00% <100.00%> (ø)
...in/com/mealkitary/address/SimpleAddressResolver.kt 100.00% <100.00%> (ø)
...n/kotlin/com/mealkitary/brn/OpenApiBrnValidator.kt 100.00% <100.00%> (ø)
...main/kotlin/com/mealkitary/brn/OpenApiWebClient.kt 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@le2sky le2sky merged commit fe3e6e2 into main Oct 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment 해치웠나? run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[기능 구현] 국세청 사업자등록정보 상태조회 서비스 연동 [개선] 가게 기능 개선
2 participants