Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[기능 구현] 신규 가게 등록 기능 구현(issue#71) #77

Merged
merged 23 commits into from
Sep 27, 2023
Merged

Conversation

le2sky
Copy link
Owner

@le2sky le2sky commented Sep 27, 2023

구현 요약

신규 가게 등록 기능을 구현했습니다.

연관 이슈
#71

@le2sky le2sky added new 기능 개발하고 싶어 run: ci ci 과정 실행 해줘~ labels Sep 27, 2023
@le2sky le2sky self-assigned this Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Test Results

210 tests   210 ✔️  22s ⏱️
  53 suites      0 💤
  53 files        0

Results for commit a321979.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #77 (a321979) into develop (2b2c20f) will increase coverage by 0.32%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop      #77      +/-   ##
=============================================
+ Coverage      94.87%   95.19%   +0.32%     
- Complexity       239      258      +19     
=============================================
  Files             52       60       +8     
  Lines            585      645      +60     
  Branches          27       31       +4     
=============================================
+ Hits             555      614      +59     
- Misses            17       18       +1     
  Partials          13       13              
Files Coverage Δ
.../com/mealkitary/shop/web/RegisterShopController.kt 100.00% <100.00%> (ø)
...lkitary/shop/web/request/RegisterShopWebRequest.kt 100.00% <100.00%> (ø)
...shop/application/port/input/RegisterShopRequest.kt 100.00% <100.00%> (ø)
...lkitary/shop/application/service/GetShopService.kt 100.00% <100.00%> (ø)
...ry/shop/application/service/RegisterShopService.kt 100.00% <100.00%> (ø)
...ain/kotlin/com/mealkitary/shop/domain/shop/Shop.kt 80.76% <100.00%> (-3.11%) ⬇️
.../mealkitary/shop/domain/shop/ShopBusinessNumber.kt 100.00% <100.00%> (ø)
...otlin/com/mealkitary/shop/domain/shop/ShopTitle.kt 100.00% <100.00%> (ø)
...mealkitary/shop/domain/shop/factory/ShopFactory.kt 100.00% <100.00%> (ø)
...ence/SpringDataJpaReservationPersistenceAdapter.kt 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner Author

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1o18z

코드 리뷰 부탁드립니다! 🙇🏻‍♂️🙇🏻‍♂️

@le2sky le2sky requested a review from 1o18z September 27, 2023 02:50
@1o18z
Copy link
Collaborator

1o18z commented Sep 27, 2023

수고하셨습니다~~!!
코멘트로 설명 하나하나 달아주셔서 코드를 읽는데 어려움이 없었어요!!🙆🏻‍♀️👍🏻👍🏻

@le2sky le2sky merged commit 0cad251 into develop Sep 27, 2023
7 checks passed
@le2sky le2sky deleted the feat/71 branch September 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new 기능 개발하고 싶어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants