refactor : 불필요한 메서드 제거

le2sky · Sep 27, 2023 · 1e7cdf2 · 1e7cdf2
1 parent 30f35e4
commit 1e7cdf2
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/ShopBusinessNumber.kt b/mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/ShopBusinessNumber.kt
@@ -5,7 +5,6 @@ import javax.persistence.Embeddable
 
 // TODO : 매번 REGEX 객체를 생성하는 것이 성능에 얼마나 영향을 미치는지 확인하고 개선
 private const val BRN_FORMAT = "([0-9]{3})-?([0-9]{2})-?([0-9]{5})"
-private const val INVALID_BRN_FORMAT_MESSAGE = "올바른 사업자번호 형식이 아닙니다."
 
 @Embeddable
 class ShopBusinessNumber private constructor(
@@ -15,21 +14,14 @@ class ShopBusinessNumber private constructor(
 
     companion object {
         fun from(brn: String): ShopBusinessNumber {
-            checkIsBrnBlank(brn)
             checkIsBrnFormat(brn)
 
             return ShopBusinessNumber(brn)
         }
 
-        private fun checkIsBrnBlank(brn: String) {
-            if (brn.isBlank()) {
-                throw IllegalArgumentException(INVALID_BRN_FORMAT_MESSAGE)
-            }
-        }
-
         private fun checkIsBrnFormat(brn: String) {
             if (!brn.matches(getBRNFormatRegex())) {
-                throw IllegalArgumentException(INVALID_BRN_FORMAT_MESSAGE)
+                throw IllegalArgumentException("올바른 사업자번호 형식이 아닙니다.")
             }
         }