Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couriers idle with PREPARE_DELIVERY status #10400

Open
4 of 5 tasks
PaintMasterPoE opened this issue Nov 4, 2024 · 31 comments
Open
4 of 5 tasks

Couriers idle with PREPARE_DELIVERY status #10400

PaintMasterPoE opened this issue Nov 4, 2024 · 31 comments
Labels
Bug Gotta squash 'em all!

Comments

@PaintMasterPoE
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20

MineColonies Version

1.1.716-snapshot

Structurize Version

1.0.760-snapshot

Related Mods and their Versions

  1. Forge 47.3.11
  2. BlockUI 1.0.156-RELEASE
  3. Domum 1.0.186-RELEASE
  4. MultiPiston 1.2.43-RELEASE

Current Behavior

Couriers idle near warehouse while having delivery tasks that shown in their huts.
image
Courier tasks.
image
image
Have PREPARING_DELIVERY status.
image
Those items are in warehouse.
image

They do deliver those items if i give them those items myself.

I looked in discord, google, tried everything. Tried different version, had older version mods previously now its same.
Tried fire, restart couriers, tried /mc colony requestsystem-reset 1, everything i found.
Tried breaking all racks and make builder repair them.

Expected Behavior

I expected courier would take items from warehouse and deliver them.

Reproduction Steps

  1. Have warehouse
  2. Have couriers

Logs

https://gist.github.com/PaintMasterPoE/9c981a1448e5da446ded7685ee0dc481

Anything else?

No response

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@PaintMasterPoE PaintMasterPoE added the Bug Gotta squash 'em all! label Nov 4, 2024
@Raycoms
Copy link
Contributor

Raycoms commented Nov 4, 2024

Is there a way to reproduce this? do you have a world where this persists over restarts?

@PaintMasterPoE
Copy link
Author

PaintMasterPoE commented Nov 4, 2024

I do, but its way more than 25mb that i can upload here

@Raycoms
Copy link
Contributor

Raycoms commented Nov 4, 2024

There is a colony export command for this

@PaintMasterPoE
Copy link
Author

colony1Export.zip

@PaintMasterPoE
Copy link
Author

Any new on this? Is it something within those mods?

@Raycoms
Copy link
Contributor

Raycoms commented Nov 5, 2024

Didn't get time for it yet.

@PaintMasterPoE
Copy link
Author

PaintMasterPoE commented Nov 5, 2024

Ok, whenever possible, meanwhile want to add a bit more, might be helpful.

Couriers work fine as long as they deliver items from other huts to warehouse.
But the moment they get task in their courier hut to deliver from warehouse, they get status PREPARE_DELIVERY and just idle, unless i give them those items myself and then they do deliver.

@Raycoms
Copy link
Contributor

Raycoms commented Nov 5, 2024

have you tried the latest already?

@PaintMasterPoE
Copy link
Author

Yeah updated today

@PaintMasterPoE
Copy link
Author

Another update. I tried 1.1.700 as it has some fixes for couriers/warehouse, i noticed that requests for delivery from warehouse are in warehouse hut rather than in courier hut as it is now. And yet its still same.

Also modpack i play CTE2 got updated today, and its still same.

I don't get it how it can happen only for me when a lot of people play with exact same mods.

@Talyda
Copy link
Contributor

Talyda commented Nov 5, 2024

Try with latest as well? .719

@PaintMasterPoE
Copy link
Author

yeah first i had 500 something, then 714, 715, 719 and 700. Tried everything i could find in discord and google

@Raycoms
Copy link
Contributor

Raycoms commented Nov 6, 2024

can't open the world because it's too heavily modded after all, I had couriers deliver things to postboxes for the same type of warehouse and that worked fine for me on the newest at least

@PaintMasterPoE
Copy link
Author

Oh well, so I guess only option left for me is trying remove mods, but idk why only I have issues when tons of people play this exact modpack, and noone has this problem.

@Raycoms
Copy link
Contributor

Raycoms commented Nov 6, 2024

okay, I figured out the problem, they can't get to the basement, as a workaround, replace the trapdoor wth a ladder

@Thodor12
Copy link
Contributor

Thodor12 commented Nov 6, 2024

Should we have some fallback in the courier AI if they are unable to reach the racks. Like can't we throw some interaction message "I have trouble reaching my destination". We technically know when a path result is unable to be computed due to blockages, so could be doable I think.

@PaintMasterPoE
Copy link
Author

PaintMasterPoE commented Nov 6, 2024

Ok, seems like removing trapdoor worked, now they deliver from warehouse.
But sometimes they get stuck on ladder or spinning in one place but i guess its known issue that other people have.
Thanks!

@PaintMasterPoE
Copy link
Author

PaintMasterPoE commented Nov 10, 2024

For some reason issue returned, couriers have task to deliver planks to builder from warehouse, planks are in warehouse, but they idle with same PREPARE_DELIVERY status. Other courier with same issue wont deliver stone swords to barracks, stone swords are in warehouse.

And there's no trapdoor lol

@Raycoms
Copy link
Contributor

Raycoms commented Nov 10, 2024

Check for a place they might not be able to path to in the warehouse

@PaintMasterPoE
Copy link
Author

For now request system reset helped, and maybe removing min stock from huts

@PaintMasterPoE
Copy link
Author

PaintMasterPoE commented Nov 12, 2024

Issue return sometimes, always same, Courier idle while need to deliver from warehouse to other hut. No trap doors in warehouse, no changes made since last time. Request reset helps until courier get request to deliver from warehouse. Updated to last version.

Really annoying because i just can't have builder build without me bringing materials, or giving them to courier manually.

@PaintMasterPoE
Copy link
Author

image
More stuff, when courier stuck, it has request from carpenter while carpenter has no requests

@Raycoms
Copy link
Contributor

Raycoms commented Nov 14, 2024 via email

@PaintMasterPoE
Copy link
Author

Not stuck, rather idle like before with prepare_delivery status. Removing trap door helped, so they do deliver, but still get stuck sometimes when they have request to deliver from warehouse, this time likely not pathfinding, but something with request system.

@Raycoms
Copy link
Contributor

Raycoms commented Nov 14, 2024

If they're in prepare delivery, they're more likely stuck in AI than in the request system

@Blackskyliner
Copy link

Blackskyliner commented Nov 22, 2024

I can confirm that removing the Trap door from the urban savanna Warehouse fixed all my courier problems. Beforehand they were just circling in the basement. Removed the trapdoor and replaced with ladder and now everything works even w/o any reset of any kind.

EDIT: Stair -> Ladder

@PaintMasterPoE
Copy link
Author

Ye i did that earlier, it helped, like before they never ever delivered stuff from warehouse, after removing trapdoor they do.

But sometimes they just stuck like before idling next to warehouse, and like before giving them items manually makes them deliver. In my case they were stuck on delivering stone swords to barracks, Have stone sword recipe learned, have stone swords in warehouse. but they idle like before when there was trap door. giving them stone swords manually worked.

@chrysillis
Copy link

I'm having the same issue in version 1.1.806-1.21.1. Courier stuck standing next to warehouse with prepare_delivery as their status despite several active requests on the warehouse.

image

This is on a level 3 Medieval Oak warehouse. The courier in the screenshot is level 2. I've already restarted their job and cancelled the existing requests.

I did a colony export as well, but it was too large to directly upload so I added it as a Dropbox link.

https://www.dropbox.com/scl/fi/vvzvdm6jjodduo0x95jss/colony1Export.zip?rlkey=074gz948b7fm3ae7n6ky0bs2y&st=6zjutrbx&dl=0

@Talyda
Copy link
Contributor

Talyda commented Nov 27, 2024

I'm having the same issue in version 1.1.806-1.21.1. Courier stuck standing next to warehouse with prepare_delivery as their status despite several active requests on the warehouse.

image

Hey, as a test, could you please remove the upside down cobblestone stair from beside the hutblock here, see if that fixes it for you? Have you asked for help on discord BTW?

@chrysillis
Copy link

Wow! That seems to have fixed it somehow. Yeah, they are working again. I searched on the Discord first and found someone with a similar issue and they were told to go report it on GitHub. So I just thought I'd respond here first then.

@Talyda
Copy link
Contributor

Talyda commented Nov 27, 2024

All good! Your world download might help the devs work it out anyway =)

And for the devs, was reported in 1.20 as well yesterday, and removing the stair also worked (1.20.1-1.1.751-snapshot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

6 participants