Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The latest release's version not matching previous version's structure #10138

Closed
4 of 5 tasks
zyxkad opened this issue Aug 19, 2024 · 4 comments
Closed
4 of 5 tasks
Labels
Bug Gotta squash 'em all!

Comments

@zyxkad
Copy link

zyxkad commented Aug 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest beta version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.1.636

Structurize Version

1.1.636-1.20.1-BETA

Related Mods and their Versions

No response

Current Behavior

Previously the version structure is <minecraft_version>-<minecolonies_version>,
but now the versions swapped, it become <minecolonies_version>-<minecraft_version>

Is this on purpose? Since it breaks our mod dependencies.

[[dependencies.${mod_id}]]
modId = "minecolonies"
mandatory = false
versionRange = "[1.20.1-1.1.472-BETA,)"
ordering = "NONE"
side = "BOTH"

image

Expected Behavior

Mod (both older version and the latest version) should load correctly without error.

Reproduction Steps

  1. Define dependencies with older version
  2. Try load with the latest version
  3. Load failed

Logs

N/A

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@zyxkad zyxkad added the Bug Gotta squash 'em all! label Aug 19, 2024
@Thodor12
Copy link
Contributor

We're aware, this is being fixed with ldtteam/OperaPublicaCreator#13

@Yzen90
Copy link

Yzen90 commented Aug 21, 2024

The file minecolonies-1.1.638-1.20.1-beta.jar at CurseForge still has this issue. I edited the mods.toml in the jar and that seemed to work.

@zyxkad
Copy link
Author

zyxkad commented Aug 21, 2024

Maybe minecolonies can temperatory remove the release until fixed.

@Thodor12
Copy link
Contributor

We're currently checking what we want to do to resolve this, we recommend not upgrading past 1.1.629 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

3 participants