Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lit test broken for Python >= 3.12 #4671

Closed
JohanEngelen opened this issue May 25, 2024 · 2 comments · Fixed by #4681
Closed

lit test broken for Python >= 3.12 #4671

JohanEngelen opened this issue May 25, 2024 · 2 comments · Fixed by #4681

Comments

@JohanEngelen
Copy link
Member

Python 3.12 no longer has the distutils package.

❯ ./runlit.py -v .
Lit version:  18.1.6
runlit.py: /Users/johan/.pyenv/versions/3.12.2/lib/python3.12/site-packages/lit/TestingConfig.py:152: fatal: unable to parse config file '/Users/johan/ldc/build17/tests/lit.site.cfg', traceback: Traceback (most recent call last):
  File "/Users/johan/.pyenv/versions/3.12.2/lib/python3.12/site-packages/lit/TestingConfig.py", line 140, in load_from_path
    exec(compile(data, path, "exec"), cfg_globals, None)
  File "/Users/johan/ldc/build17/tests/lit.site.cfg", line 10, in <module>
    from distutils.version import LooseVersion
ModuleNotFoundError: No module named 'distutils'

See ultrafunkamsterdam/undetected-chromedriver#1641 (comment) for possible fixes. I don't have gdb so can't really test what replacement works for the version testing.

@the-horo
Copy link
Contributor

the-horo commented Jun 8, 2024

The testsuite has been forking fine for me with pythont3.12 (though I don't run the gdb or the valgrind tests). Perhaps you need pip install setuptools?

@kinke
Copy link
Member

kinke commented Jun 8, 2024

Depending on a package for two little version-string comparisons seems pretty silly IMO. Especially for nowadays uber-ancient gdb versions < 8. Ubuntu 20 has v9, Debian 10 v8. I guess we can simply remove those checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants