Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading molecules for spahm #33

Closed
briling opened this issue Apr 30, 2024 · 4 comments
Closed

Loading molecules for spahm #33

briling opened this issue Apr 30, 2024 · 4 comments
Assignees

Comments

@briling
Copy link
Contributor

briling commented Apr 30, 2024

What is this supposed to do?

        mols.append(compound.xyz_to_mol(xyzfile, basis, charge=0 if ch is None else ch,
                                        spin=0 if ch is None else sp, unit=units)) #TODO

I don't understand why spin=0 if ch is None else sp

@YAY-C
Copy link
Contributor

YAY-C commented May 1, 2024

So if I remember correctly, this is done to avoid Pyscf overwriting the spin arguments, whenever the charge does not fit the number of electrons. (which suppresses the error and would give a different representation)

@YAY-C
Copy link
Contributor

YAY-C commented May 1, 2024

Though I don't know if they change this behaviour in the more recent version of PySCF ...

@briling
Copy link
Contributor Author

briling commented May 1, 2024

apparently spin=0 if ch is None else sp was a bug

@briling
Copy link
Contributor Author

briling commented May 1, 2024

fixed by #36

@briling briling closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants