From b74e838992595f6d314c38808073c8eaf53e81aa Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Sat, 19 Oct 2024 06:52:51 +1100
Subject: [PATCH] [8.16] [Security Solution][Notes] - fix an issue that breaks
 the notes management page, an enum value was missing from the api (#196912)
 (#196935)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Notes] - fix an issue that breaks the notes
management page, an enum value was missing from the api
(#196912)](https://github.com/elastic/kibana/pull/196912)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-18T18:09:02Z","message":"[Security
Solution][Notes] - fix an issue that breaks the notes management page,
an enum value was missing from the api (#196912)\n\n##
Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the
first commit,\r\nWebstorm is trying to be smart... CI should take care
of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a
small issue that prevents the notes management page to\r\nload. The
issue comes from the fact that one of the enum values passed\r\nto
filter notes was missing from the open api spec. This issue
was\r\nintroduced in this
recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent
notes management borken page\r\n![Screenshot 2024-10-18 at 10
30\r\n13 AM](https://github.com/user-attachments/assets/4926a62f-1ebf-4698-8a13-bf761d77f4ba)\r\n\r\nThis
is the error in the network tab\r\n![Screenshot 2024-10-18 at 10
30\r\n29 AM](https://github.com/user-attachments/assets/90b56246-c116-4050-bcfa-2c6668274e74)\r\n\r\nThis
PR fixes the issue\r\n![Screenshot 2024-10-18 at 10
27\r\n01 AM](https://github.com/user-attachments/assets/7d3338ce-ad73-4be5-b94c-15bcf0234680)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
fix an issue that breaks the notes management page, an enum value was
missing from the
api","number":196912,"url":"https://github.com/elastic/kibana/pull/196912","mergeCommit":{"message":"[Security
Solution][Notes] - fix an issue that breaks the notes management page,
an enum value was missing from the api (#196912)\n\n##
Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the
first commit,\r\nWebstorm is trying to be smart... CI should take care
of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a
small issue that prevents the notes management page to\r\nload. The
issue comes from the fact that one of the enum values passed\r\nto
filter notes was missing from the open api spec. This issue
was\r\nintroduced in this
recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent
notes management borken page\r\n![Screenshot 2024-10-18 at 10
30\r\n13 AM](https://github.com/user-attachments/assets/4926a62f-1ebf-4698-8a13-bf761d77f4ba)\r\n\r\nThis
is the error in the network tab\r\n![Screenshot 2024-10-18 at 10
30\r\n29 AM](https://github.com/user-attachments/assets/90b56246-c116-4050-bcfa-2c6668274e74)\r\n\r\nThis
PR fixes the issue\r\n![Screenshot 2024-10-18 at 10
27\r\n01 AM](https://github.com/user-attachments/assets/7d3338ce-ad73-4be5-b94c-15bcf0234680)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196912","number":196912,"mergeCommit":{"message":"[Security
Solution][Notes] - fix an issue that breaks the notes management page,
an enum value was missing from the api (#196912)\n\n##
Summary\r\n\r\n_**Notes: please ignore the spaces introduced in the
first commit,\r\nWebstorm is trying to be smart... CI should take care
of fixing that in\r\na second commit shortly**_\r\n\r\nThis PR fixes a
small issue that prevents the notes management page to\r\nload. The
issue comes from the fact that one of the enum values passed\r\nto
filter notes was missing from the open api spec. This issue
was\r\nintroduced in this
recent\r\n[PR](https://github.com/elastic/kibana/pull/195501).\r\n\r\nCurrent
notes management borken page\r\n![Screenshot 2024-10-18 at 10
30\r\n13 AM](https://github.com/user-attachments/assets/4926a62f-1ebf-4698-8a13-bf761d77f4ba)\r\n\r\nThis
is the error in the network tab\r\n![Screenshot 2024-10-18 at 10
30\r\n29 AM](https://github.com/user-attachments/assets/90b56246-c116-4050-bcfa-2c6668274e74)\r\n\r\nThis
PR fixes the issue\r\n![Screenshot 2024-10-18 at 10
27\r\n01 AM](https://github.com/user-attachments/assets/7d3338ce-ad73-4be5-b94c-15bcf0234680)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bf7c5aaf29e475979023a607a4f318b5f005d0d8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
---
 oas_docs/output/kibana.serverless.staging.yaml           | 1 +
 oas_docs/output/kibana.serverless.yaml                   | 1 +
 oas_docs/output/kibana.staging.yaml                      | 1 +
 oas_docs/output/kibana.yaml                              | 1 +
 .../common/api/timeline/get_notes/get_notes_route.gen.ts | 1 +
 .../api/timeline/get_notes/get_notes_route.schema.yaml   | 9 +++++----
 ..._solution_timeline_api_2023_10_31.bundled.schema.yaml | 1 +
 ..._solution_timeline_api_2023_10_31.bundled.schema.yaml | 1 +
 8 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/oas_docs/output/kibana.serverless.staging.yaml b/oas_docs/output/kibana.serverless.staging.yaml
index 2634ca5ad5959..036af4565aa6a 100644
--- a/oas_docs/output/kibana.serverless.staging.yaml
+++ b/oas_docs/output/kibana.serverless.staging.yaml
@@ -31687,6 +31687,7 @@ components:
     Security_Timeline_API_AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object
diff --git a/oas_docs/output/kibana.serverless.yaml b/oas_docs/output/kibana.serverless.yaml
index 2634ca5ad5959..036af4565aa6a 100644
--- a/oas_docs/output/kibana.serverless.yaml
+++ b/oas_docs/output/kibana.serverless.yaml
@@ -31687,6 +31687,7 @@ components:
     Security_Timeline_API_AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object
diff --git a/oas_docs/output/kibana.staging.yaml b/oas_docs/output/kibana.staging.yaml
index 647ad65e617e0..39e064efd3611 100644
--- a/oas_docs/output/kibana.staging.yaml
+++ b/oas_docs/output/kibana.staging.yaml
@@ -40452,6 +40452,7 @@ components:
     Security_Timeline_API_AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object
diff --git a/oas_docs/output/kibana.yaml b/oas_docs/output/kibana.yaml
index 647ad65e617e0..39e064efd3611 100644
--- a/oas_docs/output/kibana.yaml
+++ b/oas_docs/output/kibana.yaml
@@ -40452,6 +40452,7 @@ components:
     Security_Timeline_API_AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object
diff --git a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts
index 41615f24d011c..151fb05f41856 100644
--- a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts
+++ b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts
@@ -23,6 +23,7 @@ import { Note } from '../model/components.gen';
  */
 export type AssociatedFilterType = z.infer<typeof AssociatedFilterType>;
 export const AssociatedFilterType = z.enum([
+  'all',
   'document_only',
   'saved_object_only',
   'document_and_saved_object',
diff --git a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml
index 4873d0e90ef2a..e635018c293cf 100644
--- a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml
+++ b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml
@@ -75,10 +75,11 @@ components:
     AssociatedFilterType:
         type: string
         enum:
-            - document_only
-            - saved_object_only
-            - document_and_saved_object
-            - orphan
+          - all
+          - document_only
+          - saved_object_only
+          - document_and_saved_object
+          - orphan
         description: Filter notes based on their association with a document or saved object.
     DocumentIds:
       oneOf:
diff --git a/x-pack/plugins/security_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml b/x-pack/plugins/security_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
index ae0025305a7e7..070d7be235ef5 100644
--- a/x-pack/plugins/security_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
+++ b/x-pack/plugins/security_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
@@ -915,6 +915,7 @@ components:
     AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object
diff --git a/x-pack/plugins/security_solution/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml b/x-pack/plugins/security_solution/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
index bf59a31c8de9e..9f5882f0f4072 100644
--- a/x-pack/plugins/security_solution/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
+++ b/x-pack/plugins/security_solution/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
@@ -915,6 +915,7 @@ components:
     AssociatedFilterType:
       description: Filter notes based on their association with a document or saved object.
       enum:
+        - all
         - document_only
         - saved_object_only
         - document_and_saved_object