Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit script to build module with each commit #18

Open
tzarebczan opened this issue May 7, 2018 · 5 comments
Open

Add precommit script to build module with each commit #18

tzarebczan opened this issue May 7, 2018 · 5 comments
Labels
area: devops good first issue Good for newcomers level: 1 No knowledge of the existing code required

Comments

@tzarebczan
Copy link
Contributor

@seanyesmunt and @akinwale discussed this as a method to ensure code is not injected when modules are built locally and committed to github.

@neb-b
Copy link

neb-b commented May 10, 2018

Just spent a little time on this but I'm seeing this when adding yarn build to the precommit hook

ERROR in Flow: Out of Retries

The flow server is not responding (3 retries remaining): -The flow server is not responding (2 retries remaining): \The flow server is not responding (1 retry remaining): |The flow server is not responding (0 retries remaining): /
Out of retries, exiting!

Not really sure what's happening

@kauffj
Copy link
Member

kauffj commented May 10, 2018

It's pretty clear what's happening @seanyesmunt. You're out of retries.

@neb-b
Copy link

neb-b commented May 10, 2018 via email

@kauffj
Copy link
Member

kauffj commented May 10, 2018

I was joking.

@neb-b
Copy link

neb-b commented May 10, 2018

Once again my ability to notice jokes has failed me.

@alyssaoc alyssaoc added good first issue Good for newcomers level: 1 No knowledge of the existing code required area: devops labels Aug 3, 2018
@neb-b neb-b removed their assignment Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: devops good first issue Good for newcomers level: 1 No knowledge of the existing code required
Projects
None yet
Development

No branches or pull requests

4 participants