Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secure connection to hub #7765

Open
ben221199 opened this issue Oct 1, 2023 · 1 comment
Open

Add support for secure connection to hub #7765

ben221199 opened this issue Oct 1, 2023 · 1 comment

Comments

@ben221199
Copy link

At the moment, the SPV servers and LBRY Desktop only support plain text connections. However, for technical reasons, but also for security reasons, I think it should be a good practice if we add support for secure connections to the wallet server on port 50002. The reasons I see, are:

  • Secure connections are (mostly) able to use SNI, which (in my case) can be used for some technical tricks
  • Secure connections prevent others (e.g. the government) from spying what video's we have watched
  • MITM attacks will be not possible or at least be harder to do.

I think it is best to start making all the LBRY clients compatible with secure connections already, so that platforms which already provide secure servers can add them; after that, we can focus on upgrading the LBRY servers to a secure version too.

Note: I'm not advocating for dropping plaintext and 50001. I think we should keep that one too.

@ben221199
Copy link
Author

My suggestion for UI change is:

  • Add selector with options TCP (the default) and SSL/TLS.
  • Keep the host field, but add support for IPv6.
  • Make the port field optional. The default port (and placeholder) for TCP is 50001 and the default port (and placeholder) for SSL/TLS is 50002.

The other option is to make it just one field where you can enter in the form hostOrIP:port (TCP), tcp://hostOrIP:port (TCP), ssl://hostOrIP:port and tls://hostOrIP:port. Note that in this case, IPv6 address should definitely go between [ and ].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant