Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluating support of address labels for lbcwallet #20

Open
roylee17 opened this issue Jul 14, 2022 · 0 comments
Open

Evaluating support of address labels for lbcwallet #20

roylee17 opened this issue Jul 14, 2022 · 0 comments
Labels

Comments

@roylee17
Copy link
Collaborator

Currently, lbcwallet doesn't support address labels. This causes some issues for users to migrate their lbrycrd wallet to lbcwallet.

In some RPCs, lbcwallet overrides the meaning of "label" with "account", for example:

getnewaddress ("account" "addresstype")

Generates and returns a new payment address.

Arguments:
1. account     (string, optional) DEPRECATED -- Account name the new address will belong to (default="default")
2. addresstype (string, optional) Address type. Must be one of legacy / p2pkh, p2sh-p2wpkh / p2sh-p2wkh / p2sh-segwit, or p2wpkh / p2wkh / bech32

Result:
"value" (string) The payment address
importprivkey "privkey" ("label" rescan=true)

Imports a WIF-encoded private key to the 'imported' account.

Arguments:
1. privkey (string, required)                The WIF-encoded private key
2. label   (string, optional)                Unused (must be unset or 'imported')
3. rescan  (boolean, optional, default=true) Rescan the blockchain (since the genesis block) for outputs controlled by the imported key

The desired solution would be supporting labels, and update the RPC semantics to

getnewaddress ("account", "label", "addresstype") // support both account label
importprivkey "privkey" ("label" rescan=true) // respect label

The rest of relevant RPCs are also desired, but not blocking any integration so far.

getaddressesbylabel
getreceivedbylabel
listlabels
setlabel
@roylee17 roylee17 transferred this issue from lbryio/lbcd Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant