Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add heat pump based on DOE performance curve #1723

Open
mwetter opened this issue Jan 26, 2020 · 2 comments · May be fixed by #1731
Open

add heat pump based on DOE performance curve #1723

mwetter opened this issue Jan 26, 2020 · 2 comments · May be fixed by #1731
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented Jan 26, 2020

This issue is to add a heat pump based on the DOE performance curves.

@mwetter
Copy link
Member Author

mwetter commented Jan 26, 2020

The development branch is issue1723_heatPumpDOE

@mwetter mwetter linked a pull request Jan 31, 2020 that will close this issue
@mwetter
Copy link
Member Author

mwetter commented Feb 5, 2020

Todo:

  • Run
simulateModel("Buildings.Fluid.HeatPumps.Examples.DOE2Reversible_CoolingHeating(heaPum(scaling_factor=0.1))", stopTime=7200, method="Cvode", tolerance=1e-06, resultFile="DOE2Reversible_CoolingHeating");
plot({"heaPum.thePer.QFalLoa_flow"}, colors={{28,108,200}});

The variable QFalLoa_flow is non-zero, even when the heat pump runs at full load. The difference is due to the factor 1.2 from the part load ratio. Check what the reason is for this. See also ChillerElectricERI.cc for the EnergyPlus implementation.

  • Handle loaRat and powRat. Maybe they should be dealt with in the data record because these are data and not inherent to the physics.
  • Add documentation for data record, in particular also what conditions the COP is for.
  • Add a validation vs EnergyPlus, in particular also valid the false loading of the compressor which is an EnergyPlus output variable.
  • Add a validation for scaling_factor different from 1 (this was double counted in https://github.com/lbl-srg/modelica-buildings/pull/1724/files#diff-a933da081cf4b6de302bf0f986f77115R146 but I believe is now correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants