From dab52afe4d1b4843f0bf383cf8f53ab1b6a493b1 Mon Sep 17 00:00:00 2001 From: Casper Fu <91219266+hcasperfu@users.noreply.github.com> Date: Wed, 29 May 2024 02:42:12 -0700 Subject: [PATCH] Issue3819 mover model warnings maint 11 (#3845) * default efficiency methods now depend on pressure curve availability * added specification Examples.MoverParameter * added nominal curve specification Validation.Pump_y_stratos * added nominal curve specification Validation.FlowControlled_dp and _m_flow * added default curve specification Validation.PumpCurveDerivatives * added default curve specification Validation.FlowControlled_dpSystem * added default curve specification Examples.Tutorial.Boiler * added default curve specifications Examples.Tutorial.SpaceCooling * added default curve specification Examples..ChillerSetPointControl * added default curve specification BoilerPolynomialClosedLoop * added default curve specification Fluid.FMI, removed redundant * added default curve specification RectangularBorefield * Revert "temporarily elevated assert warnings to errors" This reverts commit df5c22b0f43bf56fb379418b20af3ecafc45a43e. * updated stats DHC * updated release notes * improved code indentation * updated release notes * rewrote change log to make it clearer sed -i 's/Added nominal curve specification to suppress warning./Specified nominalValuesDefineDefaultPressureCurve=true<\/code>\nin the mover component to suppress a warning./g' $(find . -iname '*.mo') --- .../Examples/ChillerSetPointControl.mo | 8 +++ Buildings/Examples/Tutorial/Boiler/System2.mo | 8 +++ Buildings/Examples/Tutorial/Boiler/System3.mo | 15 ++++- Buildings/Examples/Tutorial/Boiler/System4.mo | 15 ++++- Buildings/Examples/Tutorial/Boiler/System5.mo | 15 ++++- Buildings/Examples/Tutorial/Boiler/System6.mo | 15 ++++- Buildings/Examples/Tutorial/Boiler/System7.mo | 15 ++++- .../Examples/Tutorial/SpaceCooling/System2.mo | 8 +++ .../Examples/Tutorial/SpaceCooling/System3.mo | 8 +++ .../Examples/BoilerPolynomialClosedLoop.mo | 9 +++ .../FMI/ExportContainers/Examples/FMUs/Fan.mo | 8 +++ .../Examples/FMUs/HVACZones.mo | 9 +++ .../ExportContainers/Validation/RoomHVAC.mo | 8 ++- .../Examples/RectangularBorefield.mo | 8 +++ Buildings/Fluid/Movers/Data/Generic.mo | 14 ++++- .../Fluid/Movers/Examples/MoverParameter.mo | 8 +++ .../Movers/Validation/FlowControlled_dp.mo | 9 +++ .../Validation/FlowControlled_dpSystem.mo | 9 +++ .../Validation/FlowControlled_m_flow.mo | 9 +++ .../Movers/Validation/PumpCurveDerivatives.mo | 8 +++ .../Fluid/Movers/Validation/Pump_y_stratos.mo | 37 ++++++++---- ...ldings_DHC_Examples_Steam_SingleBoiler.txt | 18 +++--- ..._Examples_AirToWater2D_OneRoomRadiator.txt | 10 ++-- ...mples_CarnotWithLosses_OneRoomRadiator.txt | 10 ++-- ...LargeScaleWaterToWater_OneRoomRadiator.txt | 12 ++-- ...sible_Examples_Modular_OneRoomRadiator.txt | 10 ++-- .../UsersGuide/ReleaseNotes/Version_11_1_0.mo | 58 +++++++++++++++++++ 27 files changed, 302 insertions(+), 59 deletions(-) diff --git a/Buildings/Examples/ChillerPlant/BaseClasses/Controls/Examples/ChillerSetPointControl.mo b/Buildings/Examples/ChillerPlant/BaseClasses/Controls/Examples/ChillerSetPointControl.mo index bb0e7566329..4ff034b38d7 100644 --- a/Buildings/Examples/ChillerPlant/BaseClasses/Controls/Examples/ChillerSetPointControl.mo +++ b/Buildings/Examples/ChillerPlant/BaseClasses/Controls/Examples/ChillerSetPointControl.mo @@ -78,6 +78,7 @@ model ChillerSetPointControl MediumAir, m_flow_nominal=999) annotation (Placement(transformation(extent={{0,-70},{20,-50}}))); Buildings.Fluid.Movers.FlowControlled_m_flow pum( + nominalValuesDefineDefaultPressureCurve=true, m_flow_nominal=1.2*mCHW_flow_nominal, dp(start=40474), redeclare package Medium = Medium2, @@ -214,6 +215,13 @@ equation Documentation(revisions="