Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest specified required options #139

Open
juunone opened this issue Nov 10, 2020 · 3 comments
Open

Suggest specified required options #139

juunone opened this issue Nov 10, 2020 · 3 comments

Comments

@juunone
Copy link

juunone commented Nov 10, 2020

hi, i read and use winston-cloudwatch now
when i read readme files
there is no required tag or text in options
without aws-sdk and send log with WinstonCloudWatch have to this options

how about specified this options?

awsAccessKeyId (required)
awsSecretKey (required)
awsRegion (required)

stay safe 👍
thanks

@lazywithclass
Copy link
Owner

Hello @juunone, I'm not quite sure I've understood your problem.

Could you please paste here the code? I'll be glad to help.

@juunone
Copy link
Author

juunone commented Nov 24, 2020

hello @lazywithclass
i mean when i use WinstonCloudWatch without aws-sdk

this options be required in WinstonCloudWatch

awsAccessKeyId
awsSecretKey
awsRegion
//e.g. use case
winston.add(new WinstonCloudWatch({
  cloudWatchLogs: new AWS.CloudWatchLogs(),
  logGroupName: 'testing',
  logStreamName: 'first,
  awsAccessKeyId : 'DXXXXA2GD7JABXXXXR'
  awsSecretKey : 'xxcl40Xxxxxxxxx88mJXpKxxxxxxxxxdE' 
  awsRegion: ap-northeast-2
}));

there WinstonCloudWatch document contents not enough to explain this options.😦
This is the list of options you could pass as argument to winston.add
then i suggest specified required options in document more explain

thank you :D

@lazywithclass
Copy link
Owner

Ah I see, you're suggesting I should explain better how to configure the library? Did you have a look at the examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants