Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expectation of 10 medians on ORC page incorrect #60

Open
zack-overflow opened this issue Jul 28, 2022 · 0 comments
Open

Expectation of 10 medians on ORC page incorrect #60

zack-overflow opened this issue Jul 28, 2022 · 0 comments

Comments

@zack-overflow
Copy link

zack-overflow commented Jul 28, 2022

assert len(median_page_urls) == 10 # the registrar medians web page always keeps a list links to the past ten academic terms

This line asserts that crawling the medians from the ORC should return results from the last ten terms. Looking at the medians page from March in the Wayback machine, the previous ten terms worth of medians were listed.

Looking at the current page, however, there are only eight medians listed, so the check is throwing an error based on a false negative (it is written to expect the median crawling function to return ten terms, there are only eight this term). I don't know if this reduction in the number of terms with medians available is unique to summer, a permanent change going forward, or specific to 22X. Either way,

  1. There should be some conditionals to guard against times when fewer than ten medians are listed.
  2. I wonder if this is causing issues in prod. Is there logging set up?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant