Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the professor field on Review from StringField to ForeignKey(Instructor) #17

Open
cheniel opened this issue Dec 7, 2016 · 0 comments
Open

Convert the professor field on Review from StringField to ForeignKey(Instructor) #17

cheniel opened this issue Dec 7, 2016 · 0 comments
Labels
enhancement help wanted

Comments

@cheniel
Copy link
Member

cheniel commented Dec 7, 2016

Currently we have two sources for professors:

  • Through the professor StringField on Review, populated by review writers.
  • Through Instructor, which has a ManyToMany relationship to CourseOffering and is crawled through the timetable.

We would like to consolidate these two sources by changing professor on Review from StringField to ForeignKey. This will require a data migration.

This will consolidate the queries on the course_detail and course_professors views. ReviewForm will have to be modified as well.
@cheniel cheniel changed the title Convert professor on Review to a ForeignKey on Instructor Convert the professor field on Review from StringField to ForeignKey(Instructor) Dec 7, 2016
@lidatong lidatong mentioned this issue Mar 1, 2017
Closed
@zack-overflow zack-overflow mentioned this issue Sep 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cheniel