Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter review search #10

Open
cheniel opened this issue Sep 22, 2016 · 2 comments
Open

Smarter review search #10

cheniel opened this issue Sep 22, 2016 · 2 comments

Comments

@cheniel
Copy link
Member

cheniel commented Sep 22, 2016

Review search currently only allows single words or phrases. We should support multiple words. For example, when someone searches "difficult hard", we should surface reviews that have either "difficult" or "hard" rather than only those that have "difficult hard" (probably none).

Keep in mind we use review search to surface reviews from a specific professor. Any changes to review search should not break this. We should also make sure the search cannot become too computationally expensive (possibly by limiting the number of words).

@isaac-400
Copy link

What are the computational limits for search currently? I think that's the biggest constraint for this issue. Review search could be improved by relaxing the search rules or we could go all the way and use a full text search. Thoughts? Is this issue still relevant? I know the issues for the repo are pretty old, but I'd love to help!

@cheniel
Copy link
Member Author

cheniel commented Oct 26, 2020

cc @ziruihao @jaismith in case you didn't get a notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants