Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing above the heading #5648

Open
Muhammed-Moinuddin opened this issue Jul 7, 2024 · 20 comments · May be fixed by #6087
Open

Add spacing above the heading #5648

Muhammed-Moinuddin opened this issue Jul 7, 2024 · 20 comments · May be fixed by #6087
Assignees
Labels
component/ui Issues related to UI good first issue Good for newcomers kind/enhancement New feature or request

Comments

@Muhammed-Moinuddin
Copy link
Contributor

Current Behavior

Open Source Internship Program heading with it's title needs alignment.

Screenshot from 2024-07-08 04-31-36

Desired Behavior

Heading should have some space on top as well as on bottom (check with headings of other pages like https://layer5.io/projects)

Screenshots / Mockups

Implementation

Acceptance Tests


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Muhammed-Moinuddin Muhammed-Moinuddin added kind/enhancement New feature or request good first issue Good for newcomers component/ui Issues related to UI labels Jul 7, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

github-actions bot commented Jul 8, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@r-kundan
Copy link
Contributor

r-kundan commented Jul 8, 2024

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

Thanks for the interest. It is part of our meeting agenda today so will be assigned via meeting by the community. I recommend you to join it. https://layer5.io/community/calendar

@r-kundan
Copy link
Contributor

r-kundan commented Jul 8, 2024

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

@r-kundan
Copy link
Contributor

Screenshot 2024-07-09 at 11 46 54 AM i changed it plz check it out

@Muhammed-Moinuddin
Copy link
Contributor Author

Screenshot 2024-07-09 at 11 46 54 AM i changed it plz check it out

Kindly check my comment on your commit.

@r-kundan
Copy link
Contributor

Can you explain to me clearly what you mean? Because as you said I have added space above and below the title

@Muhammed-Moinuddin
Copy link
Contributor Author

Can you explain to me clearly what you mean? Because as you said I have added space above and below the title

Kindly check that comment, it's pretty detailed. You have done good but we can achieve code consistency with a small thing.

@CodeMaverick2
Copy link

@Muhammed-Moinuddin if the issue is still open please assign it to me I would like to solve it

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin if the issue is still open please assign it to me I would like to solve it

Thank you for interest. But it's already assigned and in progress.

@r-kundan
Copy link
Contributor

@Muhammed-Moinuddin Sir, I have updated the PR please check it

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin Sir, I have updated the PR please check it

Kindly check my comment. And let's discuss this via slack.

@I-karmayogi
Copy link

Hi @Muhammed-Moinuddin , is this issue still open?

@fakegithub01
Copy link

@Muhammed-Moinuddin @sudhanshutech i would like to solve this issue. Can u please assign me.

@Muhammed-Moinuddin
Copy link
Contributor Author

Hi @Muhammed-Moinuddin , is this issue still open?

Yes it's open now. Would you like to work on it?

@fakegithub01
Copy link

I have set it up locally and please assign this issue i will wok on it @Muhammed-Moinuddin @narasimha-1511 @sudhanshutech

@Ashparshp
Copy link
Contributor

@fakegithub01, assigned to you.

@fakegithub01 fakegithub01 removed their assignment Sep 5, 2024
@Muhammed-Moinuddin
Copy link
Contributor Author

I'll complete it.

@FaatimaAbidi
Copy link

FaatimaAbidi commented Nov 16, 2024

Hi @Muhammed-Moinuddin @sudhanshutech, is this issue still available? If so, I would like to work on it.

I have a possible fix in the following branch: https://github.com/FaatimaAbidi/layer5/tree/fix_for_headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment