Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNURLw support #4

Open
leesalminen opened this issue Dec 19, 2024 · 12 comments
Open

LNURLw support #4

leesalminen opened this issue Dec 19, 2024 · 12 comments

Comments

@leesalminen
Copy link

Hi there,

We've been testing out the wallet for Bolt Card support, looks great!

We couldn't find a way to redeem LNURLw vouchers with the wallet though. Can you confirm if there is a way currently? If not, is is something you are willing to support? I may have some time to PR you if needed.

@cuervoshi
Copy link
Collaborator

Hi Lee!
LNURLw support is currently available. If you scan a LNURLw with the wallet web app, it should take you directly to the claim process. Alternatively, you can paste the LNURLw in the transfer section, and it should guide you to the claim as well.

If this isn't working as expected, please let us know
Looking forward to your feedback.

@leesalminen
Copy link
Author

Hmm, we did try it a couple ways and didn't seem to be working as expected. Will keep trying and report back.

@leesalminen
Copy link
Author

Yeah, we just tried with 3 LNURLw QR codes from 3 different providers, didn't work. Could you give it a try on your end? Maybe we're just being dumb?

@cuervoshi
Copy link
Collaborator

Yeah, we just tried with 3 LNURLw QR codes from 3 different providers, didn't work. Could you give it a try on your end? Maybe we're just being dumb?

Could you tell me which provider you are using? I have only tested with the LNURLw extension from LNBits. Maybe they use different formats.

@leesalminen
Copy link
Author

We've tried with Blink, Bull Bitcoin & Azteco

@leesalminen
Copy link
Author

Let me try fresh, maybe they expired or something.

@leesalminen
Copy link
Author

Here's a LNURLw for 1 EUR, can't scan it from my lawallet-web.vercel.app

Uploading Screenshot 2024-12-19 at 1.07.38 PM.png…

@leesalminen
Copy link
Author

Screenshot 2024-12-19 at 1 06 13 PM

@cuervoshi
Copy link
Collaborator

Now I understand the problem.
The request to the decoded LNURL
https://lnurlv3.bullbitcoin.com/withdrawRequest?s=...
is resulting in a CORS request error.

I will try to refactor the way the request is sent to solve this problem.
Thank you very much for the report! I will keep you informed through this issue.

@leesalminen
Copy link
Author

Aha, CORS! OK, cool, I will also report to Bull Bitcoin as well. But would be good if your wallet could make the request from the backend as probably others also have this issue.

@leesalminen
Copy link
Author

Confirmed it was CORS. I got Bull Bitcoin to set up CORS on the LNURLw endpoints and now works with La Wallet.

@cuervoshi
Copy link
Collaborator

Confirmed it was CORS. I got Bull Bitcoin to set up CORS on the LNURLw endpoints and now works with La Wallet.

Good news!
I've also implemented a proxy on requests.
This feature is currently available in the add-proxy branch if you want to try it out. I'll continue to refine it before releasing it to production to make sure everything works smoothly.
Thanks for your report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants