Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS crashing after update to 3.10.3 #410

Open
dlil opened this issue Jun 18, 2021 · 5 comments
Open

VS crashing after update to 3.10.3 #410

dlil opened this issue Jun 18, 2021 · 5 comments
Labels

Comments

@dlil
Copy link

dlil commented Jun 18, 2021

Versions

  • Git Diff Margin version: 3.10.3
  • Visual Studio version: VS 2013 (12.0)

What happened

With Git Diff Margin v3.10.3, Visual Studio crashes when editing a line of source code. This appears to happen when Git Diff Margin should be updating the editor's left margin to show the modified line.

This issue does not occur with Git Diff Margin v3.10.2.

Not tested with Visual Studio versions other than 2013.

Steps to Reproduce

  1. Open a project/solution.
  2. Open a source file.
  3. Make a change to a line of source.
  4. Crash!
@dlil dlil added the bug label Jun 18, 2021
@laurentkempe
Copy link
Owner

Thanks for the report @dlil
Could you share the logs, and tell us from which version you updated? Thanks

@pmme
Copy link

pmme commented Jul 28, 2021

Same happens in VS2012

Microsoft Visual Studio Professional 2012
Version 11.0.61030.00 Update 4

Cannot tell you what version I had originally sorry.
Updated to 3.11.5 and it crashed.
Worked my way back through Github tagged releases until I got to 3.10.2 and it worked again.
In the not-working state (3.10.3+), it crashes loading the solution if GitDiffMargin is enabled and the current source file has a difference to show.

Willing to send logs but... where are they and what are they called?

@laurentkempe
Copy link
Owner

laurentkempe commented Aug 4, 2021

Thx @pmme for the report!

Willing to send logs but... where are they and what are they called?

ActivityLog.xml and ActivityLog.xsl should be in %APPDATA%\Microsoft\VisualStudio\11.0

Could you please also try to update to 3.12.1 to see if the issue is gone?

@pmme
Copy link

pmme commented Aug 4, 2021

Hello Laurent,

Re-tried with 3.11, 3.10.3 and 3.12.1 from your releases page. All of them still exhibited the same problem.

None of the test runs just now wrote those two log files.

I had found those log files at the time of my original report but they didn't appear to contain anything useful about the crash, so I didn't know if they were the files you wanted.
I'm attaching the log files as they are. I had noted that they were updated/created at the time of my original report of the problem, so perhaps they can give you some useful insight, despite no update from the latest tests.
ActivityLog 11.0.zip

For what it's worth, 3.12.1 is working fine in: Microsoft Visual Studio Professional 2019, Version 16.10.2 on the same computer, and the icons are back :).

@laurentkempe
Copy link
Owner

Hello Paul

Thanks for the logs, unfortunately you are right there is nothing useful in it 😥
Look like I will need to find a version of 2012/2013 to see what is going on, which will take some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants