🐛 Fix parsing for StreamingResponse #225
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
_ASGIMiddlewareResponder
buffers thehttp.response.start
message and delays sending it until the firsthttp.response.body
message. While this ordering adheres to the ASGI specification, it breaks streaming responses because streaming responses expecthttp.response.start
, to be sent immediately, followed by body chunks incrementally.I am not sure if there is a good reason to delay headers as you can send them immediately