Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix parsing for StreamingResponse #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rushilsrivastava
Copy link

@rushilsrivastava rushilsrivastava commented Nov 26, 2024

The current implementation of _ASGIMiddlewareResponder buffers the http.response.start message and delays sending it until the first http.response.body message. While this ordering adheres to the ASGI specification, it breaks streaming responses because streaming responses expect http.response.start, to be sent immediately, followed by body chunks incrementally.

I am not sure if there is a good reason to delay headers as you can send them immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant