feat: Add initial support for hooks #256
Conversation
|
This pull request has been linked to Shortcut Story #236778: Add hook support to ruby. |
| # | ||
| # @return [Metadata] | ||
| # | ||
| def metadata |
There was a problem hiding this comment.
I was thinking if it would be possible to force implementation of metadata. But it would probably just end up like the JS implementation. Where ultimately we end up falling back anyway.
There was a problem hiding this comment.
I could raise an exception. That would force people to implement it. Want me to make that change?
| return | ||
| end | ||
|
|
||
| @hooks.push(hook) |
There was a problem hiding this comment.
I don't remember, does ruby have threading concerns?
There was a problem hiding this comment.
Like your node implementation, I make a copy of the hooks before I begin processing, so I don't think there is a thread issue here.
There was a problem hiding this comment.
Ok. I wasn't sure if you actually had to lock the collection. In node there aren't threads, so it doesn't have to worry about any memory synchronization stuff.
There was a problem hiding this comment.
Actually in thinking about it more, I do need to do some locking. This would work fine in MRI, but jRuby would probably have some sync issues since it doesn't use a GIL.
Updated to use the concurrent package we have used elsewhere.
| # Execute the :before_evaluation stage of the evaluation series. | ||
| # | ||
| # This method will return the results of each hook, indexed into an array in the same order as the hooks. If a hook | ||
| # raised an uncaught exception, the value will be nil. |
There was a problem hiding this comment.
Would this nil propagate to the after?
There was a problem hiding this comment.
Yes. The results of this method get returned as an array. We then use that array in the after_evaluation .zip call to pair it with the appropriate hook.
🤖 I have created a release *beep* *boop* --- This release introduces a Hooks API. Hooks are collections of user-defined callbacks that are executed by the SDK at various points of interest. You can use them to augment the SDK with metrics or tracing. ## [8.4.0](8.3.1...8.4.0) (2024-04-05) ### Features * Add initial support for hooks ([#256](#256)) ([3cf16eb](3cf16eb)) ### Bug Fixes * Adjust migration variation and hook interaction ([#264](#264)) ([8067af6](8067af6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Keeler <[email protected]>
No description provided.