feature: user generated logs #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geclos
force-pushed
the
feature/upload_logs
branch
from
b4c0c98 to
b9db3dd
Compare
csansoon
reviewed
Oct 28, 2024
.../gateway/src/routes/api/v2/projects/[projectId]/versions/[versionUuid]/logs/handlers/post.ts
Outdated
Show resolved
Hide resolved
geclos
force-pushed
the
feature/upload_logs
branch
4 times, most recently
from
a919d14 to
dcee876
Compare
There was a problem hiding this comment.
Small thing: A bit weird call it post. Better create
.../gateway/src/routes/api/v2/projects/[projectId]/versions/[versionUuid]/logs/handlers/post.ts
Outdated
Show resolved
Hide resolved
geclos
force-pushed
the
feature/upload_logs
branch
9 times, most recently
from
2fae609 to
ffbf0ff
Compare
geclos
commented
Oct 28, 2024
| import { Hono } from 'hono' | ||
|
|
||
| import { chatHandler } from './handlers/chat' | ||
|
|
||
| export const chatsRouter = new Hono() | ||
|
|
||
| chatsRouter.post(ROUTES.Api.V1.Conversations.Chat, ...chatHandler) |
There was a problem hiding this comment.
I'm removing this crap, it's worse than having regular string literals even if it causes some minor duplicity
There was a problem hiding this comment.
I see conflicts in my near future
| } | ||
| }, | ||
| "types": { | ||
| "index.d.ts": "./dist/index.d.ts" | ||
| }, |
There was a problem hiding this comment.
our exports were all wrong and we weren't exporting types correctly, working on the example quickly surfaced these issues
geclos
force-pushed
the
feature/upload_logs
branch
4 times, most recently
from
4885709 to
a9e391d
Compare
geclos
force-pushed
the
feature/upload_logs
branch
from
a9e391d to
4335467
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the ability to upload user generated logs to a project. It adds a new route for uploading logs and a new page for the user to upload logs. Logs are stored in the same way as regular document logs but they lack some optional fields such as duration, cost, token count or finish reason. The only required field is the messages array.