-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unnecessary \@noitemerr in \addvspace and \addpenalty #1460
Comments
It would probably be worth noting in any ltnews description of this change that
would give a lower level |
ah yes, because it still tries
|
By the way: is there any good reason why these two commands aren't robust? If I touch them then I could change that too, using |
Brief outline of the enhancement
\addvspace
and\addpenalty
both call\@noitemerr
if they are encountered in horizontal mode. This is really a leftover from the 2.09 days, i.e., more than 30 years old. Back then, this was necessary, because the list environments changed\par
to do nothing when they started, thus calling\vskip
(which is executedd by\addvspace
) ended in a tight loop inserting\par
over and over again without ever succeeding to reach vertical mode. In 2e this behavior was changed and\par
got a definition that changed to vmode after 1000 unsuccessful attempts (and then issuing\@noitemerr
) as well.Thus, itis no longer necessary to generate this error in
\addvspace
and the only thing that it achieves today, is either an unnecessary error message (if the command is used outside a list) or generating the error message twice (if used inside a list).It should therefore be taken out and instead
\addvspace
should instead simply issue a\par
first before applying its logic.This is upward compatible since no valid LaTeX document can call
\addvspace
in hmode right now.Minimal example showing the current behaviour
The text was updated successfully, but these errors were encountered: