-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use bootstrap as a npm dependency with lasso #12
Comments
Hi @meghakrishnamurthy, for the first issue, are you seeing an error? If so, what is the error that you are seeing? Even though it is not recommended to put variables inside a URL, lasso will still attempt to resolve the URL and in 90% of cases it should work as expected. For the second issue, we are tracking this internally and I will share the details with you offline. |
@patrick-steele-idem For issue 2 - let us sync up offline. |
When we install bootstrap from npm - I use browser.json to include the less files from bootstrap.
When I do this - it throws an error since bootstrap includes font in the following format:-
https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L13-L18
As seen in lasso-less doc it is not the recommended way - https://github.com/lasso-js/lasso-less#urls
This makes it extremely hard to use bootstrap via lasso.
Secondly - I created a package that changed URL variables to relative path and published it as ebay-bootstrap, but I noticed that it fails because it is not able to publish woff2 format to the resource server.
https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L15
Woff2 is not yet supported and hence it causes errors.
The text was updated successfully, but these errors were encountered: