Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper events are being received multiple times when using the scaling function. #270

Closed
MarcelM1109 opened this issue Nov 4, 2024 · 4 comments
Assignees

Comments

@MarcelM1109
Copy link

Reverb Version

1.4.0

Laravel Version

11.8.0

PHP Version

8.2

Description

When using the scaling function in Laravel Reverb, listenForWhisper events on the client side are triggered multiple times. When Client A sends a whisper event, the listenForWhisper event on Client B is triggered more than once, despite only one whisper event being expected.

Steps To Reproduce

  1. Enable the scaling function in Laravel Reverb.
  2. Ensure both Client A and Client B join the same channel.
  3. Have Client A send a whisper event in the channel.
  4. Observe that Client B receives the whisper event multiple times instead of only once.
@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

@MarcelM1109
Copy link
Author

I just reproduced the issue again. Events are not received multiple times, but the sender of a client event does receive their own whisper when scaling is enabled. When scaling is disabled, a whisper is not received by the sender, so I assume this behavior is unintended.

@MarcelM1109
Copy link
Author

Here is the code I used to reproduce the bug:
https://github.com/MarcelM1109/bug-report

@joedixon
Copy link
Collaborator

I just reproduced the issue again. Events are not received multiple times, but the sender of a client event does receive their own whisper when scaling is enabled. When scaling is disabled, a whisper is not received by the sender, so I assume this behavior is unintended.

Looking into this a bit, I can see the issue. I'll address this soon.

@joedixon joedixon self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants