Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function in small width of terminal #3

Closed
utsavsomaiya opened this issue Jul 28, 2023 · 6 comments · Fixed by #20
Closed

Search function in small width of terminal #3

utsavsomaiya opened this issue Jul 28, 2023 · 6 comments · Fixed by #20
Labels

Comments

@utsavsomaiya
Copy link

Laravel Prompts Version

0.1.0

Laravel Version

10.16.1

PHP Version

8.2

Operating System & Version

Linux

Terminal Application

Terminal of vs code and simple Terminal

Description

If I open the terminal from vs code and press the up and down arrow then it is made a new search prompt.

In my linux terminal works fine.

prompt_issue.mp4

Steps To Reproduce

I just install laravel application and make a simple command

@devajmeireles
Copy link
Contributor

I don't know what the Laravel team thinks, but for me this isn't a problem in Prompts, or am I wrong? 🤔

@jessarcher
Copy link
Member

The search and suggest prompts need a minimum terminal height of 8 lines. The others need at least 6 lines.

I can't solve this other than throwing an error saying to increase the terminal height or reduce the font size. I could make it interactive so they can adjust the terminal size and then press enter to continue, but I'd want to see more people having the issue before going that far.

@jessarcher jessarcher added the bug label Jul 29, 2023
@utsavsomaiya
Copy link
Author

Okay, Jess Thanks..

I just want to ask something to you is Laravel using currently termwind for display the info..

Which is create a new line after info will display.. is it possible to remove the new line :

image

@utsavsomaiya
Copy link
Author

image

May be this method is not capturing the new line. 😢

@jessarcher
Copy link
Member

I just want to ask something to you is Laravel using currently termwind for display the info..

Which is create a new line after info will display.. is it possible to remove the new line :

This shouldn't be an issue once laravel/framework#46772 is merged because we're configuring Laravel to share its output buffer with Prompts, so they should be aware of each other's newlines.

In the meantime, you could add this line yourself.

@jessarcher
Copy link
Member

I've created PR #20 to display a more helpful error message when the terminal height is too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants