Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bounty instantDummyCaster #51

Open
godbit opened this issue Jan 28, 2018 · 3 comments
Open

No bounty instantDummyCaster #51

godbit opened this issue Jan 28, 2018 · 3 comments

Comments

@godbit
Copy link
Contributor

godbit commented Jan 28, 2018

I think i have figured out why we get no bounty from spells cast by instantDummy caster. It is because once the spell has been cast the owner changes so out player is no longer entitled to the bounty.

private static function finish()
   caster.setOwner(DUMMY_PLAYER, false)
   caster.removeAbility(id)
   caster.setPos(boundMax)

This is probably intended in the standard library but we need to fix this in some way.

godbit added a commit that referenced this issue Jan 28, 2018
- Mostly polished but we be nicer to cast from a dummy but issue #51 prevents this
@karlek
Copy link
Contributor

karlek commented Jan 29, 2018

Ah, yes smart! Btw, nice palette of labels.

@karlek
Copy link
Contributor

karlek commented Jan 29, 2018

What about, asking making a pull request for wurstSdlib2 with player owned dummies? If they have locust, you can't select them anyway so should be okay.

@godbit
Copy link
Contributor Author

godbit commented Jan 29, 2018

Yeah that could be a ting, for instance that you call InstantDummyCaster with a flag meaning that it will be kept for that owner.

Another one could be to add a time in the call which is the time the dummy will be kept without being released. This will allow you to cast a DoT that lasts for 10 sec and the release after say 12 sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants