Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures on main #76

Open
Robbybp opened this issue Oct 30, 2024 · 4 comments
Open

Test failures on main #76

Robbybp opened this issue Oct 30, 2024 · 4 comments

Comments

@Robbybp
Copy link

Robbybp commented Oct 30, 2024

See e.g. https://github.com/lanl-ansi/PowerModelsRestoration.jl/actions/runs/11598737054/job/32295250780

I can only reproduce the test-ac-ml-uc-heuristic failure locally. We seem to be hitting an empty array in PowerModels.calc_connected_components.

@noahrhodes
Copy link
Collaborator

I assume this update changed something that results in hitting an empty array
lanl-ansi/PowerModels.jl#914

@Robbybp
Copy link
Author

Robbybp commented Oct 30, 2024

Yeah, that's likely the culprit. Have submitted a patch upstream lanl-ansi/PowerModels.jl#933

@Robbybp
Copy link
Author

Robbybp commented Nov 23, 2024

Pulling the most recent PowerModels release, we have two failing tests on MacOS-latest (x86):

test ac redispatch: Test Failed at /Users/runner/work/PowerModelsRestoration.jl/PowerModelsRestoration.jl/test/restoration_redispatch.jl:27
  Expression: isapprox(load_power(result_sim, "1", ["1", "2", "3"]), 9.8492; atol = 1)
   Evaluated: isapprox(7.949205235219295, 9.8492; atol = 1)
test ac redispatch: Test Failed at /Users/runner/work/PowerModelsRestoration.jl/PowerModelsRestoration.jl/test/restoration_redispatch.jl:30
  Expression: gen_power(result_sim, "1", ["3", "4", "5"]) >= 8.5
   Evaluated: 8.000000018656474 >= 8.5

These are testing the result of run_restoration_redispatch(mn_data, PowerModels.ACPPowerModel, nlp_solver). Is the solution to loosen the tolerances, or are the nonunique solutions we're seeing a bug that should be resolved elsewhere?

@noahrhodes
Copy link
Collaborator

I suspect it just needs to be relaxed. I assume objective value is still identical, and gen/load increases in consecutive time steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants