Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop view fixed on frontend side. #426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

alican22
Copy link
Contributor

@alican22 alican22 commented Oct 30, 2024

Shop view is better now. But there is still many work to do.

  • Write a clean html code
  • Complete missed css codes
  • Complete missed js codes.

@lanedirt
Copy link
Owner

lanedirt commented Oct 30, 2024

Hi @alican22,

Thanks for looking into this. The frontend looks a lot better with these changes. 👍

One thing I would like to ask has to do with the assets: I see the new CSS code includes some images from the original game servers, like this example:

#shopcomponent #planet {
    background: url("//gf3.geo.gfsrv.net/cdnb2/dbba5547458345f9e3b3baa09c3ef2.jpg") no-repeat;
    height: 250px;
}

In order to have OGameX be independent of the original game the goal is to include all required assets into the repository. I already did this for all existing assets which looks like this:

#messagecontainercomponent .content .singleTab.marker {
    background: url("/img/icons/112960c1ace80c7dcb03ca88d4b6fc.png") no-repeat;
}

Could you take a look at copying over the relevant files and replacing the external paths in the CSS with the new local relative paths? This will ensure that OGameX will always properly work, now and in the future.

Thanks again! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants