Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct planet image based on planet type #141

Closed
5 tasks done
lanedirt opened this issue May 5, 2024 · 1 comment · Fixed by #195
Closed
5 tasks done

Show correct planet image based on planet type #141

lanedirt opened this issue May 5, 2024 · 1 comment · Fixed by #195
Labels
enhancement New feature or request

Comments

@lanedirt
Copy link
Owner

lanedirt commented May 5, 2024

TODO: The correct image for the planet needs to be shown in the following locations:

  • Galaxy page
  • Planet list in right sidebar
  • Planet abandon/rename popup (button on overview page)
  • Empire page (does not exist yet)
  • Note: PR Update image with all planet type and laste ogame picture #194 added more images which resulted in some duplicates. Check which version is the best to use and delete any duplicates.

A planet is always one of these types:

  1. dry
  2. desert
  3. normal
  4. jungle
  5. water
  6. ice
  7. gas

See PlanetService::getPlanetType() for how the planet type is determined.

The [planet type] + [planet position in galaxy:system] makes up the unique "image". E.g. planet 1:1:15 with type "dry" would be "dry_15".

Images are stored in /public/img/planets. Note: not all images have been added to this folder yet. Any missing images will need to be retrieved and stored in the correct folder.

@Chewbaka69
Copy link
Contributor

Chewbaka69 commented May 24, 2024

matching system of ogame to display planet by type:
planets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants