Add sf_districts table and seed with SF district info #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, @sahilda or @alex-wood would one of you mind giving it a quick look as well? |
omegabytes
approved these changes
Jun 13, 2019
alex-wood
approved these changes
Jun 13, 2019
|
This looks good - how do you plan on getting this data into production @mmoghaddam385? Generally we don't reseed prod, so the best bet would be to create a migration that imports your data. |
|
@sahilda Good point, I updated the migration to populate the districts data instead of in the seeds script. |
mmoghaddam385
force-pushed
the
add_supervisor_districts_to_db
branch
from
f00a802 to
3d9c135
Compare
mmoghaddam385
force-pushed
the
add_supervisor_districts_to_db
branch
from
3d9c135 to
8a06858
Compare
|
Sweet! Actually @mmoghaddam385 I would add it to both the seed and to a migration (the seed is useful for dev since we don't run migrations in that environment). |
|
@mmoghaddam385 @sahilda can I get an update on this PR? Anything blocking that I can help resolve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sf_districts to the database and add district info to seed data as a first step in #28. There might be a better way to format the district polys (like how they look in the bikeway_networks seed data) but I'm not sure how to do that.