Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uBit.io.face as it was a temp additional that is no longer needed. #410

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Remove uBit.io.face as it was a temp additional that is no longer needed. #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions inc/compat/MicroBitCompat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,6 @@ const uint16_t MICROBIT_ID_MBED_TICKER __attribute__ ((deprecated)) = 83;
#define MICROBIT_ID_IO_P20 ID_PIN_P20
#define MICROBIT_ID_LOGO ID_PIN_LOGO

// For MakeCode extension compat. Delete ASAP.
#define MICROBIT_ID_FACE ID_PIN_FACE

#define MICROBIT_ID_MESSAGE_BUS_LISTENER DEVICE_ID_MESSAGE_BUS_LISTENER
#define MICROBIT_ID_MULTIBUTTON_ATTACH DEVICE_ID_MULTIBUTTON_ATTACH
#define MICROBIT_ID_NOTIFY DEVICE_ID_NOTIFY
Expand Down
3 changes: 1 addition & 2 deletions model/MicroBitIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ MicroBitIO::MicroBitIO(NRF52ADC &a, TouchSensor &s) :
col4(P6),
col5(P10),
buttonA(P5),
buttonB(P11),
face(logo)
buttonB(P11)
{
pins = 33;
NRF52Pin::adc = &a;
Expand Down
7 changes: 0 additions & 7 deletions model/MicroBitIO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,6 @@ typedef enum {
#define MICROBIT_PIN_BUTTON_B P0_23
#define MICROBIT_PIN_LOGO_TOUCH P1_04

// FOR MakeCode extension compat. Delete ASAP.
#define MICROBIT_PIN_FACE_TOUCH MICROBIT_PIN_LOGO_TOUCH

// Audio
#define MICROBIT_PIN_RUN_MIC P0_20
#define MICROBIT_PIN_MIC_IN P0_05
Expand Down Expand Up @@ -338,9 +335,6 @@ typedef enum {
#define ID_PIN_P46 (DEVICE_ID_IO_P0 + 46)
#define ID_PIN_P47 (DEVICE_ID_IO_P0 + 47)

// For MakeCode extension compat. Delete ASAP.
#define ID_PIN_FACE (ID_PIN_LOGO)

//
// Saved status values to restore GPIO configurations after deep sleep
//
Expand Down Expand Up @@ -413,7 +407,6 @@ namespace codal
NRF52Pin& col5;
NRF52Pin& buttonA;
NRF52Pin& buttonB;
NRF52Pin& face; // Temporary compat for MakeCode extension. Delete ASAP.


/**
Expand Down
Loading