Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uBit.io.face as it was a temp additional that is no longer needed. #410

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Remove uBit.io.face as it was a temp additional that is no longer needed. #410

merged 1 commit into from
Mar 26, 2024

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Feb 28, 2024 •
edited
Loading

Fixes #364

@microbit-carlos microbit-carlos mentioned this pull request Feb 28, 2024
Closed
@github-actions GitHub Actions
Copy link

Build diff

Base commit: 08ba1e75fa86b2f4807a87e6b555e0efb1e712a8
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/8083420930

     VM SIZE    
 -------------- 
  +0.0%      +8    [section .heap]
  +0.0%      +4    [section .text]
  -0.2%     -12    /home/runner/work/codal-microbit-v2/codal-microbit-v2/source/main.cpp
  -1.0%     -16    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-microbit-v2/model/MicroBitIO.cpp
  -0.0%     -16    TOTAL

@microbit-carlos microbit-carlos marked this pull request as ready for review February 28, 2024 17:20
microbit-carlos
microbit-carlos commented Mar 26, 2024
View reviewed changes
Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on a call, let's remove it 💥

@microbit-carlos microbit-carlos merged commit b98f3c6 into master Mar 26, 2024
29 checks passed
@microbit-carlos microbit-carlos deleted the rm-face branch March 26, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we remove uBit.io.face alias?
1 participant
@microbit-carlos