Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document JACDAC panic codes #97

Open
pelikhan opened this issue Mar 14, 2019 · 3 comments
Open

Document JACDAC panic codes #97

pelikhan opened this issue Mar 14, 2019 · 3 comments
Assignees
Labels

Comments

@pelikhan
Copy link
Contributor

This panic code overlaps with MakeCode 909 code. Could you define all error codes used by JACDAC?

target_panic(909)

@jamesadevine
Copy link
Contributor

That's a generic assert in CODAL, not JACDAC. I need to remove all of the random asserts across the codebase. Should be defined in a header file somewhere.

@pelikhan
Copy link
Contributor Author

It actually looks like dead code in that file.

@jamesadevine
Copy link
Contributor

grep across the code base, there isn't a unified definition of CODAL_ASSERT. I was looking at fixing this up a few weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants